asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: SQL++ parser: 1. refactored asterix-aql to become asterix-la...
Date Thu, 29 Oct 2015 00:32:09 GMT
Yingyi Bu has posted comments on this change.

Change subject: SQL++ parser: 1. refactored asterix-aql to become asterix-lang-common and
asterix-lang-aql, where the former is the common part for different languages; 2. added asterix-lang-sqlpp
on top of asterix-lang-common; 3. ported parser tests, optimizer tests and
......................................................................


Patch Set 12:

(11 comments)

Till's comments inlined.

https://asterix-gerrit.ics.uci.edu/#/c/466/12/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java:

Line 35: import org.apache.asterix.lang.aql.util.FunctionUtils;
remove


https://asterix-gerrit.ics.uci.edu/#/c/466/12/asterix-app/pom.xml
File asterix-app/pom.xml:

Line 131:         </dependency> 
space


https://asterix-gerrit.ics.uci.edu/#/c/466/12/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
File asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java:

Line 68: 		StringBuilder builder = new StringBuilder();
Format


https://asterix-gerrit.ics.uci.edu/#/c/466/12/asterix-app/src/test/java/org/apache/asterix/test/dml/DmlTest.java
File asterix-app/src/test/java/org/apache/asterix/test/dml/DmlTest.java:

Line 40: 	private static final String PATH_BASE = "src" + SEPARATOR + "test" + SEPARATOR +
"resources" + SEPARATOR + "dmlts"
format


https://asterix-gerrit.ics.uci.edu/#/c/466/12/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTest.java
File asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTest.java:

Line 49: 	private static final String PATH_BASE = StringUtils
format


https://asterix-gerrit.ics.uci.edu/#/c/466/12/asterix-app/src/test/resources/parserts/queries_sqlpp/columnalias.sqlpp
File asterix-app/src/test/resources/parserts/queries_sqlpp/columnalias.sqlpp:

Line 22: With root as u
WITH u as root


Line 23: HAVING root > 0
root->u


https://asterix-gerrit.ics.uci.edu/#/c/466/12/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/clause/AbstractBinaryCorrelateClause.java
File asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/clause/AbstractBinaryCorrelateClause.java:

Line 27: public abstract class AbstractBinaryCorrelateClause implements Clause {
More reuse.


https://asterix-gerrit.ics.uci.edu/#/c/466/12/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SQLPPInlineUdfsVisitor.java
File asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SQLPPInlineUdfsVisitor.java:

Line 59:         SelectClause selectClause = new SelectClause(selectElement, null, false);
Need to inline the let clauses expressions into the returnExpr and just return the new returnExpr.


https://asterix-gerrit.ics.uci.edu/#/c/466/12/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java
File asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java:

Line 715:             "is-system-null", 1);;
additional semi colon.


Line 1248:     }
remove that.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/466
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5af4e3b692ca017ec047a1ba3b404a51beb3a2e
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message