asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1155: NULL handling of LimitClause in CloneAndSubs...
Date Wed, 28 Oct 2015 04:53:44 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1155: NULL handling of LimitClause in CloneAndSubstituteVariablesVisitor
fixed. Change-Id: Idd932f2b783454b0216a947bdb4ff35a6b101cd0
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/472/1/asterix-app/src/test/resources/runtimets/queries/user-defined-functions/udf31/udf31.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/user-defined-functions/udf31/udf31.1.ddl.aql:

Line 18:  */
I think (and this is completely subjective) that a newline here ...


Line 29: { "id": int,
... and here ...


Line 38: { for $emergency in dataset EmergencyReports
... and here would be nicer :)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/472
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd932f2b783454b0216a947bdb4ff35a6b101cd0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message