asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1153: Determine build information at runtime
Date Sat, 24 Oct 2015 01:13:18 GMT
Ian Maxon has posted comments on this change.

Change subject: ASTERIXDB-1153: Determine build information at runtime
......................................................................


Patch Set 3:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/468/3/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java
File asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java:

Line 27: import org.apache.asterix.common.config.*;
> I thought we didn't do *-includes ...
Done


https://asterix-gerrit.ics.uci.edu/#/c/468/3/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:

Line 24: import org.apache.asterix.api.http.servlet.*;
> * include ?
Done


https://asterix-gerrit.ics.uci.edu/#/c/468/3/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionAPIServletTest.java
File asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionAPIServletTest.java:

Line 54: import java.util.*;
> * includes?
Done


Line 57: import static org.mockito.Mockito.*;
> * includes?
Done


https://asterix-gerrit.ics.uci.edu/#/c/468/3/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixBuildProperties.java
File asterix-common/src/main/java/org/apache/asterix/common/config/AsterixBuildProperties.java:

Line 31:     public String getuserEmail() {
> The capitalization for these methods seems strange. Is there a reason for t
Nope, fixed.


Line 32:         return accessor.getProperty("git.build.user.email", "", PropertyInterpreters.getStringPropertyInterpreter());
> Just to make those lines shorter I'd create a private function that takes t
I made this all in vim block edit mode, so it's not any easier to do it that way :p


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/468
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie392eb0cdbd25f2f4679fba12aae4c7a496e9637
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message