asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <>
Subject Change in asterixdb[master]: ASTERIXDB-1153: Determine build information at runtime
Date Fri, 23 Oct 2015 20:53:57 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1153: Determine build information at runtime

Patch Set 3:


Looks generally good, but the are a number of formatting items that look like you've used
another formatter than usual.
Should we fix those or am I mis-remembering?
File asterix-app/src/main/java/org/apache/asterix/api/common/

Line 27: import org.apache.asterix.common.config.*;
I thought we didn't do *-includes ...
File asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/

Line 24: import org.apache.asterix.api.http.servlet.*;
* include ?
File asterix-app/src/test/java/org/apache/asterix/api/http/servlet/

Line 54: import java.util.*;
* includes?

Line 57: import static org.mockito.Mockito.*;
* includes?
File asterix-common/src/main/java/org/apache/asterix/common/config/

Line 31:     public String getuserEmail() {
The capitalization for these methods seems strange. Is there a reason for this?

Line 32:         return accessor.getProperty("", "", PropertyInterpreters.getStringPropertyInterpreter());
Just to make those lines shorter I'd create a private function that takes the accessor and
the property name and returns the property value and use that to implement all others .. but
that's probably just me :)
File asterix-common/src/main/java/org/apache/asterix/common/config/

Line 25: import java.util.*;
* includes?

Line 103:         }
Shouldn't there be whitespace between the keywords and the curly braces?
File asterix-om/src/main/java/org/apache/asterix/om/util/

Line 23: import org.apache.asterix.common.config.*;
* includes?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie392eb0cdbd25f2f4679fba12aae4c7a496e9637
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-HasComments: Yes

View raw message