asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1045: fix log file reading during recovery
Date Thu, 22 Oct 2015 06:36:41 GMT
Murtadha Hubail has submitted this change and it was merged.

Change subject: ASTERIXDB-1045: fix log file reading during recovery
......................................................................


ASTERIXDB-1045: fix log file reading during recovery

Change-Id: Ic83ee1dd2d7ba88180c25f4ec6c7aa8d0a5a7162
Reviewed-on: https://asterix-gerrit.ics.uci.edu/465
Reviewed-by: Ian Maxon <imaxon@apache.org>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
---
M asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Ian Maxon: Looks good to me, approved
  Jenkins: Verified



diff --git a/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java
b/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java
index 9900468..e0cddee 100644
--- a/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java
+++ b/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java
@@ -87,8 +87,8 @@
             return null;
         }
         if (readBuffer.position() == readBuffer.limit()) {
-            boolean eof = refillLogReadBuffer();
-            if (eof && isRecoveryMode && readLSN < flushLSN.get()) {
+            boolean hasRemaining = refillLogReadBuffer();
+            if (!hasRemaining && isRecoveryMode && readLSN < flushLSN.get())
{
                 LOGGER.severe("Transaction log ends before expected. Log files may be missing.");
                 return null;
             }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/465
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic83ee1dd2d7ba88180c25f4ec6c7aa8d0a5a7162
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>

Mime
View raw message