asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1109: Fixed deletion of records from open secondar...
Date Sat, 17 Oct 2015 00:39:08 GMT
Taewoo Kim has posted comments on this change.

Change subject: ASTERIXDB-1109: Fixed deletion of records from open secondary index
......................................................................


Patch Set 6:

(60 comments)

https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceMaterializationForInsertDeleteWithSelfScanRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceMaterializationForInsertDeleteWithSelfScanRule.java:

Line 44: public class IntroduceMaterializationForInsertDeleteWithSelfScanRule implements IAlgebraicRewriteRule
{
Actually, I'm not sure whether we need to have this materization rule for the delete case.
Anyway, for here, it's enough to copy the behavior. We need to think about it when revising
the insert and delete process.


Line 82:     private boolean checkIfInsertDeleteAndScanDatasetsSame(AbstractLogicalOperator
op, String insertDatasetName) {
insertDeleteDataSetName?


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ReplaceSinkOpWithCommitOpRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ReplaceSinkOpWithCommitOpRule.java:

Line 83:                 DeleteOperator insertDeleteOperator = (DeleteOperator) descendantOp;
deleteOperator?


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SubstitutePKFromDataScanOrUnnestRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SubstitutePKFromDataScanOrUnnestRule.java:

Line 84: public class SubstitutePKFromDataScanOrUnnestRule implements IAlgebraicRewriteRule
{
Wonderful rule! Generally, can we add more comments in the code itself? Then, I can continue
reviewing this. :-)


Line 99:         AssignOperator assign = (AssignOperator) op;
assignOp?


Line 103:         for (Mutable<ILogicalExpression> e : assign.getExpressions()) {
e -> expr?


Line 137:         AssignOperator newAssign = new AssignOperator(assign.getVariables(), newAssignExprs);
newAssignOp?


Line 144:     private boolean checkIfSubstitutable(Mutable<ILogicalOperator> op, Mutable<ILogicalOperator>
projectRef,
Especially for this function, please put more comments inside of this function.


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-delete-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-delete-secondary-index-btree-composite.aql:

Line 25:     l_orderkey: int32, 
Can we remove these spaces?


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-delete-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-delete-secondary-index-btree.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-delete-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-delete-secondary-index-keyword.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-delete-secondary-index-ngram.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-delete-secondary-index-ngram.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-insert-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-insert-secondary-index-btree-composite.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-insert-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-insert-secondary-index-btree.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-insert-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-insert-secondary-index-keyword.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-insert-secondary-index-ngram.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/scan-insert-secondary-index-ngram.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-delete-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-delete-secondary-index-btree-composite.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-delete-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-delete-secondary-index-btree.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-delete-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-delete-secondary-index-keyword.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-delete-secondary-index-ngram.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-delete-secondary-index-ngram.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-insert-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-insert-secondary-index-btree-composite.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-insert-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-insert-secondary-index-btree.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-insert-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-insert-secondary-index-keyword.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-insert-secondary-index-ngram.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-insert-secondary-index-ngram.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-insert-secondary-index-rtree.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-index/unnest-insert-secondary-index-rtree.aql:

Line 38:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-delete-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-delete-secondary-index-btree-composite.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-delete-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-delete-secondary-index-btree.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-delete-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-delete-secondary-index-keyword.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-delete-secondary-index-ngram.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-delete-secondary-index-ngram.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-insert-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-insert-secondary-index-btree-composite.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-insert-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-insert-secondary-index-btree.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-insert-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-insert-secondary-index-keyword.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-insert-secondary-index-ngram.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/scan-insert-secondary-index-ngram.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-delete-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-delete-secondary-index-btree-composite.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-delete-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-delete-secondary-index-btree.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-delete-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-delete-secondary-index-keyword.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-insert-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-insert-secondary-index-btree-composite.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-insert-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-insert-secondary-index-btree.aql:

Line 25:     l_orderkey: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-insert-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-insert-secondary-index-keyword.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-insert-secondary-index-ngram.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-insert-secondary-index-ngram.aql:

Line 25:     id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-insert-secondary-index-rtree.aql
File asterix-app/src/test/resources/optimizerts/queries/nested-open-index/unnest-insert-secondary-index-rtree.aql:

Line 37:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-delete-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-delete-secondary-index-btree-composite.aql:

Line 43:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-delete-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-delete-secondary-index-btree.aql:

Line 43:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-delete-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-delete-secondary-index-keyword.aql:

Line 31:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-delete-secondary-index-rtree.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-delete-secondary-index-rtree.aql:

Line 34:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-insert-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-insert-secondary-index-btree-composite.aql:

Line 45:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-insert-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-insert-secondary-index-btree.aql:

Line 45:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-insert-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-insert-secondary-index-keyword.aql:

Line 32:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-insert-secondary-index-rtree.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/scan-insert-secondary-index-rtree.aql:

Line 35:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-delete-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-delete-secondary-index-btree-composite.aql:

Line 44:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-delete-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-delete-secondary-index-btree.aql:

Line 43:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-delete-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-delete-secondary-index-keyword.aql:

Line 31:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-delete-secondary-index-rtree.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-delete-secondary-index-rtree.aql:

Line 34:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-insert-secondary-index-btree-composite.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-insert-secondary-index-btree-composite.aql:

Line 45:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-insert-secondary-index-btree.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-insert-secondary-index-btree.aql:

Line 45:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-insert-secondary-index-keyword.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-insert-secondary-index-keyword.aql:

Line 32:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-insert-secondary-index-ngram.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-insert-secondary-index-ngram.aql:

Line 24:   id: int32, 
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-insert-secondary-index-rtree.aql
File asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/unnest-insert-secondary-index-rtree.aql:

Line 35:   
Also, here: trailing spaces


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/results/disjunction-to-join-delete-1.plan
File asterix-app/src/test/resources/optimizerts/results/disjunction-to-join-delete-1.plan:

Line 13:                         -- STREAM_PROJECT  |PARTITIONED|
Why these deletions happened?


https://asterix-gerrit.ics.uci.edu/#/c/439/6/asterix-app/src/test/resources/optimizerts/results/nested-open-index/inverted-index-join/leftouterjoin-probe-pidx-with-join-edit-distance-check-idx_01.plan
File asterix-app/src/test/resources/optimizerts/results/nested-open-index/inverted-index-join/leftouterjoin-probe-pidx-with-join-edit-distance-check-idx_01.plan:

Line 78:                                                     -- SPLIT  |PARTITIONED|
Actually here, below the SPLIT, they are not the same as the original operators in the first
SPLIT. I am not sure it's OK to remove operators in the plan in this case.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/439
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41bde91401f67918365de7df19dd2f0de20c73d2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message