asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Hillery (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-976: CSV support for all basic types
Date Tue, 13 Oct 2015 06:30:32 GMT
Chris Hillery has posted comments on this change.

Change subject: ASTERIXDB-976: CSV support for all basic types
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/444/1/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AIntervalPrinter.java
File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AIntervalPrinter.java:

Line 37: 
> Hmm, is the effect here that nothing's printed? Is that intended?
No, that was a mistake. Missed it because there are no constructors for invervals in AQL,
I don't believe, so the test cases don't cover it. I have restored the exception here as I'm
not sure how best to represent intervals.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/444
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a515efd2bbf25895537413b45eb0992484c7412
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: Yes

Mime
View raw message