asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ildar Absalyamov (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1058: make Asterix compatible with lazy LSM memory...
Date Fri, 09 Oct 2015 07:01:58 GMT
Ildar Absalyamov has posted comments on this change.

Change subject: ASTERIXDB-1058: make Asterix compatible with lazy LSM memory allocation
......................................................................


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/408/6/asterix-common/src/test/java/org/apache/asterix/test/aql/TestsUtils.java
File asterix-common/src/test/java/org/apache/asterix/test/aql/TestsUtils.java:

Line 213:                 System.out.println("None JSON Error Mesesage : " + errorBody);
Could this exception instead be rethrown upwards with a proper message?
In cluster setup who know where would stdout be redirected? On the other hand the callsite
already manages to properly log the thrown exception


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/408
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ea1eb129fe3043d43b077473dc29d17a97dfcc2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message