asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Young-Seok Kim (Code Review)" <>
Subject Change in asterixdb[master]: ASTERIXDB-1045: Log analysis fixes
Date Thu, 08 Oct 2015 01:29:46 GMT
Young-Seok Kim has posted comments on this change.

Change subject: ASTERIXDB-1045: Log analysis fixes

Patch Set 14:


Please address comments.
File asterix-common/src/main/java/org/apache/asterix/common/transactions/

Line 160:         if(buffer.remaining() < (Integer.SIZE + Byte.SIZE)/Byte.SIZE) {
better be defining constants such as LOG_TYPE_SIZE, JOB_ID_SIZE. Also, below all the size
related stuff can be replaced with appropriately defined Constants.
File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/

Line 105:                 }
what if the record's status is BAD_CHKSUM? Also, below, we should distinguish the return value
for BAD_CHKSUM and TRUNCATED since truncated seems a legal state, but BAD_CHKSUM in any case
should be considered as illegal state, right? So, truncated case can return null, but bad-chksum
should throw exception, right?

Line 172:                 read =;
Can we explain briefly the read() method behavior so that code reader understands why we do

Line 220:             eof = refillLogReadBuffer();
should be 

eof = !refillLogReadBuffer();

instead of 

eof = refillLogReadBuffer();

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I1658e938eb0f199f748407361ffee4833aac661c
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Murtadha Hubail <>
Gerrit-Reviewer: Young-Seok Kim <>
Gerrit-HasComments: Yes

View raw message