asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1045: Log analysis fixes
Date Tue, 06 Oct 2015 01:57:47 GMT
Ian Maxon has posted comments on this change.

Change subject: ASTERIXDB-1045: Log analysis fixes
......................................................................


Patch Set 12:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/289/12/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java
File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java:

Line 34: public class LogReader implements ILogReader {
> on unrelated note to the change. Just add a comment that this class is not 
Done


Line 171:                 }
> Lets add a print statement (System.out.println("waiting for IO on file " + 
There's something wrong with other changes as well so it looks like it's not caused (or solved
by) something here unfortunately.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/289
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1658e938eb0f199f748407361ffee4833aac661c
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message