asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1045: Log analysis fixes
Date Tue, 06 Oct 2015 01:56:36 GMT
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/289

to look at the new patch set (#13).

Change subject: ASTERIXDB-1045: Log analysis fixes
......................................................................

ASTERIXDB-1045: Log analysis fixes

-Avoid using exceptions for control flow in LogRecord
-Rename LogPage and ilk to LogBuffer
-Busywait on read() to fill entire buffer for fillLogBuffer rather than failing
-Distinguish between log truncation and checksum corruption

TODOs:
- Log IO and parsing still happen in lock-step.
- Busywaiting for read to return something other than 0 is unfortunate

Change-Id: I1658e938eb0f199f748407361ffee4833aac661c
---
R asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogBuffer.java
M asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java
M asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
M asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/LockManager.java
R asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBuffer.java
M asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
M asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogPageReader.java
M asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java
8 files changed, 184 insertions(+), 83 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/89/289/13
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/289
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1658e938eb0f199f748407361ffee4833aac661c
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>

Mime
View raw message