asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Adding 'cleanjson' output format, along with implementation ...
Date Fri, 02 Oct 2015 23:19:16 GMT
Ian Maxon has posted comments on this change.

Change subject: Adding 'cleanjson' output format, along with implementation of lists.
......................................................................


Patch Set 7: Code-Review+1

(3 comments)

Just a few nits

https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMessageService.java
File asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMessageService.java:

Line 76:                 LOGGER.warning("LOSSLESS_JSON exception in parsing message " + message
+ " exception [" + jse.getMessage() + "]");
s/JSON/LOSSLESS_JSON/g isn't quite right here :)


https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-common/src/main/java/org/apache/asterix/common/feeds/message/FeedMessageService.java
File asterix-common/src/main/java/org/apache/asterix/common/feeds/message/FeedMessageService.java:

Line 76:                 LOGGER.warning("LOSSLESS_JSON Exception in parsing message " + message);
Ditto...


https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-om/src/main/java/org/apache/asterix/formats/base/IDataFormat.java
File asterix-om/src/main/java/org/apache/asterix/formats/base/IDataFormat.java:

Line 67: 
Can getJSONPrinterFactoryProvider be changed to getLosslessJSONPrinterFactoryProvider?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/361
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c37d3b5aad7f286eba1cb8cb5f05ad456a6521c
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message