Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3983F18B45 for ; Wed, 16 Sep 2015 21:38:48 +0000 (UTC) Received: (qmail 97790 invoked by uid 500); 16 Sep 2015 21:38:48 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 97763 invoked by uid 500); 16 Sep 2015 21:38:48 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 97754 invoked by uid 99); 16 Sep 2015 21:38:48 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Sep 2015 21:38:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A30A41A20F4 for ; Wed, 16 Sep 2015 21:38:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id qpyrzzTC3PRW for ; Wed, 16 Sep 2015 21:38:42 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTP id 440FC204C8 for ; Wed, 16 Sep 2015 21:38:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id EF069240FB8; Wed, 16 Sep 2015 14:36:26 -0700 (PDT) Date: Wed, 16 Sep 2015 14:36:26 -0700 From: "Till Westmann (Code Review)" To: Heri Ramampiaro CC: Chen Li , Jenkins , Ian Maxon Reply-To: tillw@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Fixed failing tests on external data/udf X-Gerrit-Change-Id: Ibdb5074d0e0d4fb2b7d4303aa405c9fc90f4bd09 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2deafead6ad0144c7171abcefe4802de4e9e156d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20150916213626.EF069240FB8@unhygienix.ics.uci.edu> Till Westmann has posted comments on this change. Change subject: Fixed failing tests on external data/udf ...................................................................... Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/378/2/asterix-doc/src/site/markdown/udf.md File asterix-doc/src/site/markdown/udf.md: Line 52: Could you remove the tabs and end-of-line whitespace before submitting? https://asterix-gerrit.ics.uci.edu/#/c/378/2/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java File asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java: Line 96: private static DataInputStream dis = new DataInputStream(baais); Is it safe to share these between all threads in a VM? https://asterix-gerrit.ics.uci.edu/#/c/378/2/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java: Line 32: }*/ Could we just remove the commented Java code? -- To view, visit https://asterix-gerrit.ics.uci.edu/378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdb5074d0e0d4fb2b7d4303aa405c9fc90f4bd09 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes