Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 88CC810AF8 for ; Tue, 15 Sep 2015 04:59:54 +0000 (UTC) Received: (qmail 74766 invoked by uid 500); 15 Sep 2015 04:59:54 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 74741 invoked by uid 500); 15 Sep 2015 04:59:54 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 74732 invoked by uid 99); 15 Sep 2015 04:59:54 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Sep 2015 04:59:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 05BAFC0041 for ; Tue, 15 Sep 2015 04:59:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.127 X-Spam-Level: ** X-Spam-Status: No, score=2.127 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jNzftU-fbtWp for ; Tue, 15 Sep 2015 04:59:45 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTP id E0C49207EA for ; Tue, 15 Sep 2015 04:59:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 64B60240F7B; Mon, 14 Sep 2015 21:57:32 -0700 (PDT) Date: Mon, 14 Sep 2015 21:57:32 -0700 From: "Ian Maxon (Code Review)" CC: Jenkins , Till Westmann , Chris Hillery Reply-To: imaxon@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Change License Headers X-Gerrit-Change-Id: I09bc388089e515d7f51fd39c31bfbbc9f00cf84f X-Gerrit-ChangeURL: X-Gerrit-Commit: b1ff873caee35b09cfcd0fd3a3725f618a6ddde9 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20150915045732.64B60240F7B@unhygienix.ics.uci.edu> Ian Maxon has posted comments on this change. Change subject: Change License Headers ...................................................................... Patch Set 4: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/388/4/LICENSE.txt File LICENSE.txt: Line 308: For portions of the Asterix API examples at: > A newline between the sections? Sure. https://asterix-gerrit.ics.uci.edu/#/c/388/4/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/GregorianCalendarSystem.java File asterix-om/src/main/java/org/apache/asterix/om/base/temporal/GregorianCalendarSystem.java: Line 46 > Is this (does it need to be) in the NOTICE? Ohh, Hmm, I was thinking since it was apache licensed it wasn't an issue. But I guess the copyright is what matters. I'll add it in. -- To view, visit https://asterix-gerrit.ics.uci.edu/388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09bc388089e515d7f51fd39c31bfbbc9f00cf84f Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Chris Hillery Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes