asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Young-Seok Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Introducing data replication API to LSM indexes
Date Mon, 21 Sep 2015 04:04:02 GMT
Young-Seok Kim has posted comments on this change.

Change subject: Introducing data replication API to LSM indexes
......................................................................


Patch Set 4:

(2 comments)

I left a comment and questions.

https://asterix-gerrit.ics.uci.edu/#/c/322/4/hyracks/hyracks-api/src/main/java/edu/uci/ics/hyracks/api/replication/IReplicationJob.java
File hyracks/hyracks-api/src/main/java/edu/uci/ics/hyracks/api/replication/IReplicationJob.java:

Line 23:         METADATA
Why metadata should be a special case?


Line 29:         STOP
STOP should be control message instead of normal replication message. Also, is there any possibility
that the stopped replication can be resumed?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80565fc9d74e30440d2df5917911904ba8f33c25
Gerrit-PatchSet: 4
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message