asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Preston Carman (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Merging with the current master (+ Correcting RecordBuilder ...
Date Fri, 18 Sep 2015 19:23:43 GMT
Preston Carman has posted comments on this change.

Change subject: Merging with the current master (+ Correcting RecordBuilder instatiation in
RecordAddFieldsDescriptor)
......................................................................


Patch Set 10:

(3 comments)

Just a few minor comments.

https://asterix-gerrit.ics.uci.edu/#/c/298/10/asterix-app/src/test/resources/runtimets/queries/records/RecordsQueries.xml
File asterix-app/src/test/resources/runtimets/queries/records/RecordsQueries.xml:

Line 15: <test-case FilePath="records">
Why change the indentation?


https://asterix-gerrit.ics.uci.edu/#/c/298/10/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterix-app/src/test/resources/runtimets/testsuite.xml:

Line 6789:     <test-group name="deep-equal">
Can you add these tests similar to the Records tests? Separate file that is referenced here.


https://asterix-gerrit.ics.uci.edu/#/c/298/10/asterix-doc/src/site/markdown/aql/functions.md
File asterix-doc/src/site/markdown/aql/functions.md:

Line 2545: 		
I see these red highlights. Do you know what these are? Are these unexpected whitespace?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/298
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3621ebdd71c7cd91b50d77a972ad863cea7fcbc2
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Heri Ramampiaro <heriram@gmail.com>
Gerrit-Reviewer: Heri Ramampiaro <heriram@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message