asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heri Ramampiaro (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fixed failing tests on external data/udf
Date Thu, 17 Sep 2015 08:00:39 GMT
Heri Ramampiaro has posted comments on this change.

Change subject: Fixed failing tests on external data/udf
......................................................................


Patch Set 2:

(3 comments)

Thank you, Till for the comments. I have now addressed as explained below.

Cheers,
-heri

https://asterix-gerrit.ics.uci.edu/#/c/378/2/asterix-doc/src/site/markdown/udf.md
File asterix-doc/src/site/markdown/udf.md:

Line 52:         
> Could you remove the tabs and end-of-line whitespace before submitting?
Done


https://asterix-gerrit.ics.uci.edu/#/c/378/2/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
File asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java:

Line 96:     private static DataInputStream dis = new DataInputStream(baais);
> Is it safe to share these between all threads in a VM?
Ah, thank you pointing this out.  We do not actually need to use the DataInputStream anymore
as we are now deserialize the String directly from OutputStream, which should be synchronized
already (though this could affect the performance). I have removed this code part now.


https://asterix-gerrit.ics.uci.edu/#/c/378/2/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java:

Line 32:     }*/
> Could we just remove the commented Java code?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/378
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdb5074d0e0d4fb2b7d4303aa405c9fc90f4bd09
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Heri Ramampiaro <heriram@gmail.com>
Gerrit-Reviewer: Chen Li <chenli@gmail.com>
Gerrit-Reviewer: Heri Ramampiaro <heriram@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message