Mailing-List: contact dev-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
MIME-Version: 1.0
In-Reply-To: <A3EED1E5-84C0-4C61-9B98-DFA7147D45CB@gmail.com>
References: <0D2C9C57-3ECC-4754-A2D4-BF2B31D07AEF@gmail.com> <A3EED1E5-84C0-4C61-9B98-DFA7147D45CB@gmail.com>
From: Ian Maxon <imaxon@uci.edu>
Date: Fri, 8 Dec 2017 18:44:08 -0800
Message-ID: <CAN_YF5xkQi8u29h2ye20MyKEGnEOW1g1YU-0hncevWWgQYJdAw@mail.gmail.com>
Subject: Re: [jira] [Commented] (ASTERIXDB-2157) Parsing metadata of UDF with
 UnorderedList return type
To: dev@asterixdb.apache.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
archived-at: Sat, 09 Dec 2017 02:44:33 -0000

Change is up here: https://asterix-gerrit.ics.uci.edu/#/c/2211/, I'll
email him and the reviewers since I am not sure whether or not he is
on this list.

On Fri, Dec 8, 2017 at 4:42 PM, abdullah alamoudi <bamousaa@gmail.com> wrot=
e:
> Ian,
> Let's not drop this?
>
> Cheers,
> Abdullah.
>
>
>> Begin forwarded message:
>>
>> From: abdullah alamoudi <bamousaa@gmail.com>
>> Subject: Re: [jira] [Commented] (ASTERIXDB-2157) Parsing metadata of UDF=
 with UnorderedList return type
>> Date: November 7, 2017 at 8:38:47 PM PST
>> To: dev@asterixdb.apache.org
>> Cc: notifications@asterixdb.incubator.apache.org
>>
>> Hi Tomasz,
>> Thanks for creating the issue and for the fix.
>>
>> @Ian,
>> I looked at the PR and it looked good to me. How can we get this in? thr=
ough Gerrit?
>>
>> Cheers,
>> Abdullah.
>>
>>> On Nov 7, 2017, at 1:21 PM, Tomasz Paw=C5=82owski (JIRA) <jira@apache.o=
rg> wrote:
>>>
>>>
>>>   [ https://issues.apache.org/jira/browse/ASTERIXDB-2157?page=3Dcom.atl=
assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D16242901#comment-16242901 ]
>>>
>>> Tomasz Paw=C5=82owski commented on ASTERIXDB-2157:
>>> ---------------------------------------------
>>>
>>> I have already created a pull request for this bug https://github.com/a=
pache/asterixdb/pull/6 including a proper unit test.
>>>
>>>> Parsing metadata of UDF with UnorderedList return type
>>>> ------------------------------------------------------
>>>>
>>>>               Key: ASTERIXDB-2157
>>>>               URL: https://issues.apache.org/jira/browse/ASTERIXDB-215=
7
>>>>           Project: Apache AsterixDB
>>>>        Issue Type: Bug
>>>>        Components: MTD - Metadata
>>>>          Reporter: Tomasz Paw=C5=82owski
>>>>          Priority: Minor
>>>>            Labels: easyfix, newbie
>>>>
>>>> While defining a library UDF with return_type representing a unordered=
 list (eg. {{ ASTRING }}). UDF is created with result type {{ {{ ASTRING }}=
 }}.
>>>> This error can be replicated with libraryFunction:
>>>> <libraryFunction>
>>>>     <function_type>SCALAR</function_type>
>>>>     <name>test</name>
>>>>     <arguments>ASTRING</arguments>
>>>>     <return_type>{{ ASTRING }}</return_type>
>>>>     <definition>org.apache.asterix.external.library.TestFactory</defin=
ition>
>>>>   </libraryFunction>
>>>> TestFactory.java:
>>>> package org.apache.asterix.external.library;
>>>> import org.apache.asterix.external.api.IExternalScalarFunction;
>>>> import org.apache.asterix.external.api.IFunctionFactory;
>>>> public class TestFactory implements IFunctionFactory {
>>>>   @Override
>>>>   public IExternalScalarFunction getExternalFunction() {
>>>>       return new TestFunction();
>>>>   }
>>>> }
>>>> // END of TestFactory.java
>>>> TestFunction.java:
>>>> package org.apache.asterix.external.library;
>>>> import org.apache.asterix.external.api.IExternalScalarFunction;
>>>> import org.apache.asterix.external.api.IFunctionHelper;
>>>> import org.apache.asterix.external.library.java.JObjects;
>>>> import org.apache.asterix.om.types.BuiltinType;
>>>> public class TestFunction implements IExternalScalarFunction {
>>>>   private JObjects.JUnorderedList results;
>>>>   @Override
>>>>   public void deinitialize() {}
>>>>   @Override
>>>>   public void evaluate(IFunctionHelper functionHelper) throws Exceptio=
n {
>>>>       JObjects.JString input =3D (JObjects.JString) functionHelper.get=
Argument(0);
>>>>       results.reset();
>>>>       JObjects.JUnorderedList test =3D new JObjects.JUnorderedList(Bui=
ltinType.ASTRING);
>>>>       test.add(input);
>>>>       test.add(input);
>>>>       test.add(input);
>>>>       results.add(test);
>>>>       functionHelper.setResult(results);
>>>>   }
>>>>   @Override
>>>>   public void initialize(IFunctionHelper functionHelper) throws Except=
ion{
>>>>       results =3D (JObjects.JUnorderedList) functionHelper.getResultOb=
ject();
>>>>   }
>>>> }
>>>> // END of TestFunction.java
>>>> And executing (AQL):
>>>> use dataverse test;
>>>> testlib#test("test")
>>>> Which results in:
>>>> {{ {{ "test", "test", "test" }} }}
>>>> At the same time writing TestFunction evaluate to return {{ ASTRING }}=
 results in error:
>>>> org.apache.hyracks.algebricks.common.exceptions.AlgebricksException: j=
ava.io.EOFException
>>>>     at org.apache.asterix.optimizer.rules.ConstantFoldingRule$Constant=
FoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:2=
31)
>>>>     at org.apache.asterix.optimizer.rules.ConstantFoldingRule$Constant=
FoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:1=
53)
>>>>     at org.apache.hyracks.algebricks.core.algebra.expressions.ScalarFu=
nctionCallExpression.accept(ScalarFunctionCallExpression.java:55)
>>>>     at org.apache.asterix.optimizer.rules.ConstantFoldingRule$Constant=
FoldingVisitor.transform(ConstantFoldingRule.java:163)
>>>>     at org.apache.hyracks.algebricks.core.algebra.operators.logical.Ab=
stractAssignOperator.acceptExpressionTransform(AbstractAssignOperator.java:=
67)
>>>>     at org.apache.asterix.optimizer.rules.ConstantFoldingRule.rewriteP=
ost(ConstantFoldingRule.java:150)
>>>>     at org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleCo=
ntroller.rewriteOperatorRef(AbstractRuleController.java:126)
>>>>     at org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleCo=
ntroller.rewriteOperatorRef(AbstractRuleController.java:100)
>>>>     at org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleCo=
ntroller.rewriteOperatorRef(AbstractRuleController.java:100)
>>>>     at org.apache.hyracks.algebricks.compiler.rewriter.rulecontrollers=
.SequentialFixpointRuleController.rewriteWithRuleCollection(SequentialFixpo=
intRuleController.java:53)
>>>>     at org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptim=
izer.runOptimizationSets(HeuristicOptimizer.java:102)
>>>>     at org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptim=
izer.optimize(HeuristicOptimizer.java:82)
>>>>     at org.apache.hyracks.algebricks.compiler.api.HeuristicCompilerFac=
toryBuilder$1$1.optimize(HeuristicCompilerFactoryBuilder.java:90)
>>>>     at org.apache.asterix.api.common.APIFramework.compileQuery(APIFram=
ework.java:267)
>>>>     at org.apache.asterix.app.translator.QueryTranslator.rewriteCompil=
eQuery(QueryTranslator.java:1834)
>>>>     at org.apache.asterix.app.translator.QueryTranslator.lambda$handle=
Query$1(QueryTranslator.java:2307)
>>>>     at org.apache.asterix.app.translator.QueryTranslator.createAndRunJ=
ob(QueryTranslator.java:2407)
>>>>     at org.apache.asterix.app.translator.QueryTranslator.deliverResult=
(QueryTranslator.java:2340)
>>>>     at org.apache.asterix.app.translator.QueryTranslator.handleQuery(Q=
ueryTranslator.java:2319)
>>>>     at org.apache.asterix.app.translator.QueryTranslator.compileAndExe=
cute(QueryTranslator.java:370)
>>>>     at org.apache.asterix.app.translator.QueryTranslator.compileAndExe=
cute(QueryTranslator.java:253)
>>>>     at org.apache.asterix.api.http.server.ApiServlet.post(ApiServlet.j=
ava:153)
>>>>     at org.apache.hyracks.http.server.AbstractServlet.handle(AbstractS=
ervlet.java:78)
>>>>     at org.apache.hyracks.http.server.HttpRequestHandler.handle(HttpRe=
questHandler.java:70)
>>>>     at org.apache.hyracks.http.server.HttpRequestHandler.call(HttpRequ=
estHandler.java:55)
>>>>     at org.apache.hyracks.http.server.HttpRequestHandler.call(HttpRequ=
estHandler.java:36)
>>>>     at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>>>>     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExe=
cutor.java:1142)
>>>>     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolEx=
ecutor.java:617)
>>>>     at java.lang.Thread.run(Thread.java:745)
>>>> Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: jav=
a.io.EOFException
>>>>     at org.apache.hyracks.api.exceptions.HyracksDataException.create(H=
yracksDataException.java:45)
>>>>     at org.apache.asterix.dataflow.data.nontagged.serde.AUnorderedList=
SerializerDeserializer.deserialize(AUnorderedListSerializerDeserializer.jav=
a:102)
>>>>     at org.apache.asterix.dataflow.data.nontagged.serde.AUnorderedList=
SerializerDeserializer.deserialize(AUnorderedListSerializerDeserializer.jav=
a:43)
>>>>     at org.apache.asterix.dataflow.data.nontagged.serde.AUnorderedList=
SerializerDeserializer.deserialize(AUnorderedListSerializerDeserializer.jav=
a:96)
>>>>     at org.apache.asterix.dataflow.data.nontagged.serde.AUnorderedList=
SerializerDeserializer.deserialize(AUnorderedListSerializerDeserializer.jav=
a:43)
>>>>     at org.apache.asterix.formats.nontagged.SerializerDeserializerProv=
ider$1.deserialize(SerializerDeserializerProvider.java:191)
>>>>     at org.apache.asterix.formats.nontagged.SerializerDeserializerProv=
ider$1.deserialize(SerializerDeserializerProvider.java:173)
>>>>     at org.apache.asterix.optimizer.rules.ConstantFoldingRule$Constant=
FoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:2=
28)
>>>>     ... 29 more
>>>> Caused by: java.io.EOFException
>>>>     at java.io.DataInputStream.readInt(DataInputStream.java:392)
>>>>     at org.apache.asterix.dataflow.data.nontagged.serde.AUnorderedList=
SerializerDeserializer.deserialize(AUnorderedListSerializerDeserializer.jav=
a:92)
>>>>     ... 35 more
>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.4.14#64029)
>>
>