Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 782EA200CA3 for ; Thu, 1 Jun 2017 17:24:42 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 76A8D160BC4; Thu, 1 Jun 2017 15:24:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 95A4B160BB5 for ; Thu, 1 Jun 2017 17:24:41 +0200 (CEST) Received: (qmail 62139 invoked by uid 500); 1 Jun 2017 15:24:40 -0000 Mailing-List: contact dev-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list dev@asterixdb.apache.org Received: (qmail 62122 invoked by uid 99); 1 Jun 2017 15:24:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Jun 2017 15:24:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1A687C1471 for ; Thu, 1 Jun 2017 15:24:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.396 X-Spam-Level: X-Spam-Status: No, score=-0.396 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.796, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Z1FakG8KL69r for ; Thu, 1 Jun 2017 15:24:37 +0000 (UTC) Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2C32A5F2AE for ; Thu, 1 Jun 2017 15:24:36 +0000 (UTC) Received: by mail-pf0-f173.google.com with SMTP id 9so30094642pfj.1 for ; Thu, 01 Jun 2017 08:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=31rRb4JrilkagzEG35YC1RV1ShQ9s6Lkda97NrqyryU=; b=XOVvYD9k8DEC0wAS152FbH35p+PNnLVy9CXIzbNyfgRzRTp+HYch/48pa0sJbjYaaR 0X5NhurcHxybmCXpRZDX/WZRMs1L0S757pCsuzs1I6DPbDO5weZzGSdAMuBkgIme9zM2 rLj22v4F2UBU2gre+cOgN1RSP3bsajP5HE2z+z05ibq3iOfgOzob30gKU6OXlhHron8A Zc/OXJVxgYw0w06wIv0bzI41B7q/b/YX6dvfhP5x8/d5Zo2cGulfMk/KOGaIPhVciBig BTEAWGtMAMY3rPttXziye0CsjBBIhLoyzankUWzEErD/re2jvCW6izb+aycCa3DCASM9 Qvqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=31rRb4JrilkagzEG35YC1RV1ShQ9s6Lkda97NrqyryU=; b=LXZn50KT0lrfNISYqxkFHTU0xUzRhV5eocjRUlOuJJtMXItBfEVXPe9YBn/Y0qQO4j tYlO6CwwSBbx9AUMwU3XoImFa1fGt7ROIc1nhDITb44r6SJjE9pFvZBTGRcHDYK7RJb6 Nfn/AyCd0TI7x37Cx/FtlxelUn+efgnaJ1+EZk9eUKT3AuIxZU0Wly/lredANPBfKzlO tjuyPy26j3ifHvlo9s6gIjfeWquLoBm8rj5pH9H+W9eMnzpY0tN7WP7Pxz8hJx6cdw31 NwA/faqE/v46OZAccCMFixrl8uT8R28GbZJ0xmi4G6Nzitkm20X/ogpHBoNFOcD5N+yE 6uuA== X-Gm-Message-State: AODbwcBePZz0oD/PVeUj9JndIHowleiyE1/6CbCWN3L5lzU/zlZvrUsl heC1mkqxYCA13Rj1K5JdDE6g4eqRkw== X-Received: by 10.99.127.83 with SMTP id p19mr1589340pgn.51.1496330669143; Thu, 01 Jun 2017 08:24:29 -0700 (PDT) MIME-Version: 1.0 References: <6B9B4359-E132-466F-B8D8-FC05EC59867D@gmail.com> <12B311F4-7B74-4EAD-96E8-4FB32F31C4D2@apache.org> In-Reply-To: From: Michael Blow Date: Thu, 01 Jun 2017 15:24:18 +0000 Message-ID: Subject: Re: Modules that could be removed? To: dev@asterixdb.apache.org Content-Type: multipart/alternative; boundary="94eb2c1b5926003ecb0550e7a2e6" archived-at: Thu, 01 Jun 2017 15:24:42 -0000 --94eb2c1b5926003ecb0550e7a2e6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable +1 on understanding the BAD issues. CB folks are regularly making coordinated changes across two, three+ repos, and things work pretty well. We do have a way less painful way of linking changes instead of ref spec, but other than that things are probably not too dissimilar mechanics-wise. Our biggest issue is that unlike BAD breakages, there's not easy visibility by way of the -1 vote on Gerrit for the CB extension. If experiments does move out (and gets an indicator on Gerrit), perhaps CB extension can provide feedback there as well. On Thu, Jun 1, 2017 at 10:53 AM Mike Carey wrote: > Likewise - I thought so too - so we should figure out what isn't working > with the extensions model! > > (We do need a good model for things that don't belong in the main open > source system but that we want to run tests on regularly so that we're > hyper-aware of breakages.) > > Note that I've always anecdotally gotten the impression that the > experiments package is kind of a mess/hack and makes use of things that > aren't necessarily intended to be used. I would much much, much rather > that performance-related packages live outside the system and be banned > from doing things that normal clients cannot do... I think this would > be a lot better for the integrity of the system (as otherwise it creates > weird dependencies, non-guaranteed assumptions/contracts, and also keeps > us from having a good/safe answer to outside cries for ways to replicate > our reported performance results). > > Just my $0.005. > > Cheers, > > Mike > > > On 5/31/17 10:39 PM, Till Westmann wrote: > > Hmm, I thought that the BAD model wasn=E2=80=99t working too badly =E2= =80=A6 little do I > > know. > > > > On the other hand it seems that the module isn=E2=80=99t actually used = - at > > least it > > seems that there were no changes in the module related to experiments > > since > > we merged repositories. Is that right? Or has somebody worked on that > > module > > recently? > > > > Cheers, > > Till > > > > On 31 May 2017, at 22:20, Steven Jacobs wrote: > > > >> My two cents on this is that the BAD model doesn't work well, so I'd > >> personally be against following it. I would vote to keep it inside as > >> well. > >> Steven > >> > >> On Wed, May 31, 2017 at 10:02 PM abdullah alamoudi > >> wrote: > >> > >>> If that is the case (which makes sense), then keeping it inside and > >>> cleaning it up might be the better approach. > >>> > >>> > >>>> On May 31, 2017, at 8:45 PM, Ildar Absalyamov < > >>> ildar.absalyamov@gmail.com> wrote: > >>>> > >>>> The real challenge is that separate repo should not the treated as > >>> /dev/null for old code. > >>>> I believe that committing changes, that causes this repo to be broke= n > >>> *must* be treated as -1 Jenkins bit. > >>>> > >>>>> On May 31, 2017, at 16:41, Yingyi Bu wrote: > >>>>> > >>>>> +1. > >>>>> > >>>>> Best=EF=BC=8C > >>>>> Yingyi > >>>>> > >>>>> On Wed, May 31, 2017 at 4:22 PM, Till Westmann > >>> wrote: > >>>>> > >>>>>> I read this discussion that Ildar=E2=80=99s suggestion to move > >>> asterix-experiments > >>>>>> to a different repo would be a solution that works for everybody. > >>>>>> > >>>>>> Did I read that correctly or did someone disagree with such an > >>> approach? > >>>>>> > >>>>>> Cheers, > >>>>>> Till > >>>>>> > >>>>>> > >>>>>> On 31 May 2017, at 16:14, Mike Carey wrote: > >>>>>> > >>>>>> This should be decided by more knowlegeable folks than me - it jus= t > >>> seems > >>>>>>> "weird" to me that that's in the main code base and not outside > >>>>>>> (as a > >>> super > >>>>>>> useful client package). > >>>>>>> > >>>>>>> > >>>>>>> On 5/31/17 4:12 PM, Chris Hillery wrote: > >>>>>>> > >>>>>>>> If we move asterix-experiments out, we would need to change the > >>> current > >>>>>>>> Perf job at Couchbase. However I think the change would > >>>>>>>> actually make > >>>>>>>> that > >>>>>>>> job less complicated, at least if that allowed one to use a > >>> pre-compiled > >>>>>>>> Asterix distribution for experiments rather than requiring the > >>>>>>>> full > >>>>>>>> source > >>>>>>>> code to be available. > >>>>>>>> > >>>>>>>> Ceej > >>>>>>>> aka Chris Hillery > >>>>>>>> > >>>>>>>> On Wed, May 31, 2017 at 2:53 PM, Yingyi Bu > >>> wrote: > >>>>>>>> > >>>>>>>> The code in asterix-experiments is not well organized, e.g.: > >>>>>>>>> > >>>>>>>>> https://github.com/apache/asterixdb/tree/master/asterixdb/ > >>>>>>>>> > >>> asterix-experiments/src/main/java/org/apache/asterix/experiment/build= er > >>>>>>>>> https://github.com/apache/asterixdb/tree/master/asterixdb/ > >>>>>>>>> > >>> asterix-experiments/src/main/java/org/apache/asterix/experiment/repor= t > >>>>>>>>> > >>>>>>>>> Can anyone who actively uses asterix-experiments clean up the > >>>>>>>>> code? > >>>>>>>>> > >>>>>>>>> An alternative approach would be to put it in a separate github > >>> repo, > >>>>>>>>> if > >>>>>>>>> it is relatively independent of AsterixDB. > >>>>>>>>> > >>>>>>>>> Best, > >>>>>>>>> Yingyi > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> On Wed, May 31, 2017 at 12:31 PM, Ian Maxon > >>>>>>>>> wrote: > >>>>>>>>> > >>>>>>>>> I also would vouch for keeping asterix-experiments in. > >>> 'asterix-tools' > >>>>>>>>>> and the others could probably go. > >>>>>>>>>> > >>>>>>>>>> On Wed, May 31, 2017 at 11:58 AM, Taewoo Kim > >>>>>>>>>> > >>>>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> @Ildar: +1 > >>>>>>>>>>> > >>>>>>>>>>> Best, > >>>>>>>>>>> Taewoo > >>>>>>>>>>> > >>>>>>>>>>> On Wed, May 31, 2017 at 11:57 AM, Ildar Absalyamov < > >>>>>>>>>>> ildar.absalyamov@gmail.com> wrote: > >>>>>>>>>>> > >>>>>>>>>>> I found Young-Seok=E2=80=99s asterix-experiment package usefu= l for > >>> everyone, > >>>>>>>>>>>> > >>>>>>>>>>> who > >>>>>>>>> > >>>>>>>>>> is doing any kind of experiments. > >>>>>>>>>>>> Can we instead make an =E2=80=98asterix-contrib=E2=80=99 rep= o and move it > >>>>>>>>>>>> there, > >>> the > >>>>>>>>>>>> > >>>>>>>>>>> same > >>>>>>>>>> > >>>>>>>>>>> way we did with asterix-bad? > >>>>>>>>>>>> We can also launch an automated build in Jenkins to verify i= t > >>> builds > >>>>>>>>>>>> against master, again the same way BAD is working. This > >>>>>>>>>>>> package > >>> does > >>>>>>>>>>>> > >>>>>>>>>>> not > >>>>>>>>> > >>>>>>>>>> have a lot of dependencies, so it will be fairly painless to > >>> maintain > >>>>>>>>>>>> > >>>>>>>>>>> it. > >>>>>>>>>> > >>>>>>>>>>> On May 31, 2017, at 09:06, Yingyi Bu > >>>>>>>>>>> wrote: > >>>>>>>>>>>>> > >>>>>>>>>>>>> Hi dev, > >>>>>>>>>>>>> > >>>>>>>>>>>>> I wonder if the following potentially obsolete modules > >>>>>>>>>>>>> could > >>> be > >>>>>>>>>>>>> > >>>>>>>>>>>> moved > >>>>>>>>>> > >>>>>>>>>>> out of the AsterixDB code base: > >>>>>>>>>>>>> -- asterix-experiment > >>>>>>>>>>>>> -- asterix-tools > >>>>>>>>>>>>> -- hyracks-dist > >>>>>>>>>>>>> -- hyracks-sever > >>>>>>>>>>>>> > >>>>>>>>>>>>> Any thoughts? > >>>>>>>>>>>>> > >>>>>>>>>>>>> Best, > >>>>>>>>>>>>> Yingyi > >>>>>>>>>>>>> > >>>>>>>>>>>> Best regards, > >>>>>>>>>>>> Ildar > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>> > >>>> Best regards, > >>>> Ildar > >>>> > >>> > >>> > > --94eb2c1b5926003ecb0550e7a2e6--