asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann" <ti...@apache.org>
Subject Re: Exception refactoring proposal
Date Fri, 06 Jan 2017 23:27:44 GMT
Hi,

I like the proposal and I’d like to propose on more change:
Let’s not start the names of ErrorCodes with "ERROR_".
In the code they are usually used as

     ErrorCode.ERROR_THIS_IS_THE_PROBLEM

and it seems that

     ErrorCode.THIS_IS_THE_PROBLEM

would work just as well.

Thoughts?

Cheers,
Till


On 5 Jan 2017, at 11:12, Yingyi Bu wrote:

> Hi dev,
>
>     I recent made a change that moved some exception error message
> templates from the source code into properties files [1]. Here is an
> exception refactoring proposal [2].
>
>     I propose that:
>     --  from now on, we all follow the proposal when we want to throw
> exceptions, and enforce the key design during our code reviews.
>     --  for existing code that does not follow the proposal, we 
> refactor
> them gradually according to the proposal.
>
>     Feel free to share your thoughts.
>     Thanks!
>
> Best,
> Yingyi
>
> [1] https://asterix-gerrit.ics.uci.edu/#/c/1410/
> [2] 
> https://cwiki.apache.org/confluence/display/ASTERIXDB/Exception+Handling

Mime
View raw message