Mailing-List: contact dev-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
From: "Till Westmann" <tillw@apache.org>
To: dev@asterixdb.apache.org
Subject: Re: Line limit (120) is not enforced for an assignment statement.
Date: Tue, 25 Oct 2016 16:26:58 -0700
Message-ID: <D4F7086E-8EE4-45A2-A795-D511F1DE04AE@apache.org>
In-Reply-To: <CABytAGrt2199Ds30XsxmcHUji7adFx-Ge4vKkATAzNHc8WF78w@mail.gmail.com>
References: <CABytAGrt2199Ds30XsxmcHUji7adFx-Ge4vKkATAzNHc8WF78w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; markup=markdown
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 25 Oct 2016 23:27:01 -0000

+1

On 25 Oct 2016, at 13:29, Taewoo Kim wrote:

> There is a formatter issue regarding an assignment statement whose =

> length
> is over 120. An example is as follows:
>     private final IBinaryComparator strLowerCaseTokenCmp =3D
> AqlBinaryComparatorFactoryProvider.UTF8STRING_LOWERCASE_TOKEN_POINTABLE=
_INSTANCE.createBinaryComparator();
>
> Currently, the formatter doesn't wrap this line into two lines because =

> "No
> Wrap" policy is applied. So, I would like to propose the following =

> change.
> After applying this change, we can keep the hard limit (120) well.
>
> AsterixCodeFormatProfile.xml
>
> Line Wrapping -> Expressions -> Assignments
>
> (Before) Line Wrapping Policy: Do not Wrap
> (After) Wrap where necessary
>
> @Yingyi: I wonder whether your proposed change (do not remove blank =

> lines
> in the comment section) is already applied to the format file. Please =

> let
> me know. Then, I will download the file from
> https://cwiki.apache.org/confluence/download/attachments/61322291/Aster=
ixCodeFormatProfile.xml
> and apply my change and upload the file.