Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 95254200BA4 for ; Sat, 15 Oct 2016 19:23:35 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 93A69160AF1; Sat, 15 Oct 2016 17:23:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DAC5C160AD9 for ; Sat, 15 Oct 2016 19:23:34 +0200 (CEST) Received: (qmail 15153 invoked by uid 500); 15 Oct 2016 17:23:33 -0000 Mailing-List: contact dev-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list dev@asterixdb.apache.org Received: (qmail 15137 invoked by uid 99); 15 Oct 2016 17:23:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Oct 2016 17:23:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 349FEC026B for ; Sat, 15 Oct 2016 17:23:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.379 X-Spam-Level: ** X-Spam-Status: No, score=2.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id AFH4IjnTiRkq for ; Sat, 15 Oct 2016 17:23:32 +0000 (UTC) Received: from mail-oi0-f54.google.com (mail-oi0-f54.google.com [209.85.218.54]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 6128F5FCEF for ; Sat, 15 Oct 2016 17:23:32 +0000 (UTC) Received: by mail-oi0-f54.google.com with SMTP id t73so170940975oie.1 for ; Sat, 15 Oct 2016 10:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=eqn/STA/dYY1SUk+qcQBzr8KVsfuKxLy2Dqew8b+79A=; b=Ql8jkDqojYAH6nDKIZbA/FKyUjJUzWR9blMc1E8w3UAwWvemw6plDAFwzqv6AeC34M t3ACJmnq9B/bKjv2GaBDCA78kE84YcfNjdgu1SOAgQsYUwHr0SvIXXt6e/y4YrGWQ2lK F7gVFvBlOI5tRUU645l5NTqfmEnb4P+K0oUl6iKVhjq865/tdmGeOXkBNxnVKbOdOHss 6ybp+nd33fB2fUtmu/VUHL9Gj7y5nppx64qrwI4op1/gL+tTaEAnzw5I4MFk6eL2NlTB WNCgpNcUb2GYEaLuCXauOGHjdQ1cADQoGJAkoSRB1Qet6qnu+6YjxQYFZwwf3lV7ZHil 3OIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=eqn/STA/dYY1SUk+qcQBzr8KVsfuKxLy2Dqew8b+79A=; b=WmAkCxrlT3jBybx8zwokFSaaMk3ZUHSph5fMHTvR1qaRZN6BR4vOyJdaXpdLd7X8UG ZSYxDutU3nePIlD0AE2l1ECtpv1sLSSqRMChWtoD46vt+0rUikvV7lKb5Ndk+b1pmLvG ANg4Y6imbHJgR817kX1sNgRIz6Sgc7QDrVj8UNenooDKS6eHd0f3iRfqTSjDejYEps1D O/I215TH0jY+SzAHOCzy9uaIBf//wxjr6R9d9whIJ6LnC19zka+qBDtWrAJZugt2GHXI whskpTD9iLxtfZQ7TjVyN+ovoZ5KYmrEJlkn0QwOTktPQuUwAIXkUrjf/evn62l39ro0 RehQ== X-Gm-Message-State: AA6/9RkAmnCcHh9fTRugfis33Y6aAPYENFdituS8bDAxaqEMmC9e2be/T2Ldtm0wad6C0g== X-Received: by 10.157.35.23 with SMTP id j23mr8294470otb.243.1476552211715; Sat, 15 Oct 2016 10:23:31 -0700 (PDT) Received: from mikejcarey.local ([2600:8802:4500:fc:193b:9a10:427f:5792]) by smtp.googlemail.com with ESMTPSA id a62sm8218997oic.16.2016.10.15.10.23.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Oct 2016 10:23:30 -0700 (PDT) Subject: Re: Function name and format change in the codebase To: dev@asterixdb.apache.org References: From: Mike Carey Message-ID: <21fad68e-79ab-3889-914e-d563ddccbdf0@gmail.com> Date: Sat, 15 Oct 2016 10:23:29 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------1EBE71004B255663E14D88ED" archived-at: Sat, 15 Oct 2016 17:23:35 -0000 --------------1EBE71004B255663E14D88ED Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Agreed - yes to both. On 10/14/16 6:36 PM, Till Westmann wrote: > I think that the answer to both questions is "yes". > > My 2c, > Till > > On 14 Oct 2016, at 18:04, Taewoo Kim wrote: > >> Hi All, >> >> I would like to talk about 1) Function name convention and Format change in >> the codebase. >> >> 1) Function name >> When we invent a new function name, would it be better if we avoid using >> '-'(dash) in a new function name and use "_" instead to avoid two versions >> for the same function in AQL and SQL++? >> >> 2) Format change in the codebase >> When we modify a java source file, is it better to apply format changes to >> the whole file or the lines that we only touch? For history perspective, I >> think the latter is desirable. >> >> Best, >> Taewoo --------------1EBE71004B255663E14D88ED--