asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yingyi Bu <buyin...@gmail.com>
Subject Re: Line limit (120) is not enforced for an assignment statement.
Date Tue, 25 Oct 2016 23:34:29 GMT
>> @Yingyi: I wonder whether your proposed change (do not remove blank lines
>> in the comment section) is already applied to the format file

It looks that I haven't...
You can update this row:

<setting id=
"org.eclipse.jdt.core.formatter.comment.clear_blank_lines_in_javadoc_comment"
value="false"/>

Thanks!

Yingyi


On Tue, Oct 25, 2016 at 4:26 PM, Till Westmann <tillw@apache.org> wrote:

> +1
>
>
> On 25 Oct 2016, at 13:29, Taewoo Kim wrote:
>
> There is a formatter issue regarding an assignment statement whose length
>> is over 120. An example is as follows:
>>     private final IBinaryComparator strLowerCaseTokenCmp =
>> AqlBinaryComparatorFactoryProvider.UTF8STRING_LOWERCASE_TOKE
>> N_POINTABLE_INSTANCE.createBinaryComparator();
>>
>> Currently, the formatter doesn't wrap this line into two lines because "No
>> Wrap" policy is applied. So, I would like to propose the following change.
>> After applying this change, we can keep the hard limit (120) well.
>>
>> AsterixCodeFormatProfile.xml
>>
>> Line Wrapping -> Expressions -> Assignments
>>
>> (Before) Line Wrapping Policy: Do not Wrap
>> (After) Wrap where necessary
>>
>> @Yingyi: I wonder whether your proposed change (do not remove blank lines
>> in the comment section) is already applied to the format file. Please let
>> me know. Then, I will download the file from
>> https://cwiki.apache.org/confluence/download/attachments/
>> 61322291/AsterixCodeFormatProfile.xml
>> and apply my change and upload the file.
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message