asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From abdullah alamoudi <bamou...@gmail.com>
Subject Re: Location of test results
Date Sun, 02 Oct 2016 15:13:01 GMT
+1

Cheers,
~Abdullah.

> On Oct 2, 2016, at 4:21 AM, Till Westmann <tillw@apache.org> wrote:
> 
> Hi,
> 
> in a recent change [1] the test result location changed from "a directory in
> the module folder" to "a directory in the target folder". So now
> a) the test results will get removed with every "mvn clean" and
> b) we don’t need to exclude the test result directories in .gitignore
>   anymore.
> Both of those seem to be good effects.
> However, this change wasn’t announced to anybody (I saw it in a review,
> but didn’t think about it too much) and so in the latest change [2] we added
> the result directories again (probably because those directories were still
> around and showing up in "git status").
> 
> I think that moving the test results to the target directory was a good step
> and that
> 1) everybody should remove the old result locations from their local trees
>   and
> 2) we should remove those directories from .gitignore again.
> 
> Thoughts? Concerns? Better ideas?
> 
> Cheers,
> Till
> 
> [1] https://github.com/apache/asterixdb/commit/e4b318f650379daa8b3c6fc133ee5f7c5bcafc41
> [2] https://github.com/apache/asterixdb/commit/6f7c5312d46b4d1ad22123821b6cd589d3c88413


Mime
View raw message