Mailing-List: contact dev-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
MIME-Version: 1.0
In-Reply-To: <B4281D20-0996-41A9-B5ED-FF7576DDD8CC@apache.org>
References: <B4281D20-0996-41A9-B5ED-FF7576DDD8CC@apache.org>
From: Taewoo Kim <wangsaeu@gmail.com>
Date: Thu, 11 Aug 2016 14:46:21 -0700
Message-ID: <CABytAGps9Z+uZ3Y1VDdqst+gdn6qJ8wv42V6kyhrXbE-TXuAYg@mail.gmail.com>
Subject: Re: index-only plans
To: dev@asterixdb.apache.org
Content-Type: multipart/alternative; boundary=001a11440ef496149c0539d2b3ab
archived-at: Thu, 11 Aug 2016 21:46:46 -0000

--001a11440ef496149c0539d2b3ab
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Thanks Till for reviewing this giant patch set.

At this moment, what I can try to do is removing all necessary test cases
and changes that are related to full-text search preparation (changing the
function name of "contains" to "string-contains") since I thought this
index-only plan branch could be merged first.

I tried to separate logical LIMIT push-down to the index search and
index-only plan. But, it turns out that it was hard. Other than this, all
changes are related to index-only plan part (most of them are accessMethod
related.) In addition, Young-Seok already had one round.


Best,
Taewoo

On Thu, Aug 11, 2016 at 2:43 PM, Till Westmann <tillw@apache.org> wrote:

> Hi,
>
> we still have the big change on index-only plans outstanding. I think tha=
t
> it would be good to have that feature. However, at it=E2=80=99s current s=
ize (+45K
> lines, -15K lines) it is very (!) difficult to review. So I think that on=
e
> approach to get there would be to break it down into smaller more
> achievable
> steps.
> I=E2=80=99ve added a few comments to the review with thoughts I had to do=
 that.
> What do you think?
> Is that a good approach? Is it feasible?
> Are there other ways?
>
> Thanks for your thoughts,
> Till
>

--001a11440ef496149c0539d2b3ab--