asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann" <ti...@apache.org>
Subject Re: Cross project changes
Date Wed, 01 Jun 2016 02:18:03 GMT
Very nice.

Thanks!
Till

On 31 May 2016, at 18:02, Michael Blow wrote:

> I've added this by repurposing the Jenkins -> Gerrit plugin we're used 
> to
> relay SonarQube comments.
>
> Any patchsets which touch both asterix & hyracks will receive a 
> warning
> review comment added, to help raise awareness to the reviewers.
>
> e.g.
>
> *WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:*
>
>
>    - *asterixdb*
>       - *hyracks-fullstack*
>
> *PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!*
>
>
> Thanks,
>
> -MDB
>
>
> On Fri, May 27, 2016 at 4:34 PM, Yingyi Bu <buyingyi@gmail.com> wrote:
>
>> Ok, that shouldn't be a problem:-)
>>
>> Best,
>> Yingyi
>>
>> On Fri, May 27, 2016 at 1:33 PM, Till Westmann <tillw@apache.org> 
>> wrote:
>>
>>> This is only about notifications, there should be no limitations on 
>>> being
>>> able to do anything. Do you think that the notifications would be
>>> problematic for the reviewers of your changes?
>>>
>>> Cheers,
>>> Till
>>>
>>>
>>> On 27 May 2016, at 10:35, Yingyi Bu wrote:
>>>
>>> Can we do that after we move algebricks as a top-level module?
>>>> Many of my changes/fixes span algebricks and asterixdb.
>>>> Today we have:
>>>> -- asterixdb
>>>> -- hyracks-fullstack
>>>>
>>>> I think we should have the following structure at top level:
>>>> -- asterixdb
>>>> -- algbericks
>>>> -- hyracks
>>>>
>>>> Best,
>>>> Yingyi
>>>>
>>>> On Fri, May 27, 2016 at 10:32 AM, Till Westmann <tillw@apache.org>
>> wrote:
>>>>
>>>> Any thoughts on this? Would it be  difficult to add such 
>>>> notifications
>> to
>>>>> the
>>>>> Gerrit review?
>>>>>
>>>>> Cheers,
>>>>> Till
>>>>>
>>>>>
>>>>> On 23 May 2016, at 9:51, Till Westmann wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>>>
>>>>>> to increase the chances that Hyracks stays generic enough for 
>>>>>> other
>>>>>> projects
>>>>>> to build upon, I think that it’d be good if we alerted 
>>>>>> committers and
>>>>>> reviewers of cross project changes.
>>>>>>
>>>>>> Could we e.g. automatically flag changes that change AsterixDB 
>>>>>> and
>>>>>> Hyracks
>>>>>> with a comment on the Gerrit review? That way we'd have a 
>>>>>> reminder for
>>>>>> each
>>>>>> patchset to look at the cross-project modifications.
>>>>>>
>>>>>> Thoughts?
>>>>>>
>>>>>> Cheers,
>>>>>> Till
>>>>>>
>>>>>>
>>>>>
>>

Mime
View raw message