Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CAHWyyRyVOU34qDO5Hv1oJKUfVJJ=uK=Ybv9SzixzFwER_Z5hOg@mail.gmail.com>
References: <CANXevJTYG1iQTpc6dgFPwvuKHt_BWydecuDKVHeGx7NJvNSSpw@mail.gmail.com>
	<98B478C0-167B-4584-A5D9-312012DD5847@apache.org>
	<2B382C91818C51E9.d1d88564-a987-4615-ba44-540ccb995e1e@mail.outlook.com>
	<CAHWyyRwUoDp56=JBEe+t2BvCbzjhXL=WXBhOuHMyOST7UiZS1Q@mail.gmail.com>
	<2B382C91818C51E9.58f6e315-8fbd-4f49-ac57-2cee04c33b66@mail.outlook.com>
	<CAHWyyRyVOU34qDO5Hv1oJKUfVJJ=uK=Ybv9SzixzFwER_Z5hOg@mail.gmail.com>
Date: Fri, 20 May 2016 16:45:13 +0530
Message-ID: <CANXevJRbP_6gJeCxUTGK36Y4843XSE-wWx4aKROk7yVC_U8tAA@mail.gmail.com>
Subject: Re: Commencing work on ASTERIXDB-1375 : Revise web UI
From: Kaveen Rodrigo <u.k.k.rodrigo@gmail.com>
To: dev@asterixdb.incubator.apache.org, chillery@hillery.land
Content-Type: multipart/alternative; boundary=001a114b415c6f5e7805334434cc
archived-at: Fri, 20 May 2016 11:15:24 -0000

--001a114b415c6f5e7805334434cc
Content-Type: text/plain; charset=UTF-8

Thanks Chris,

that cleared a lot of things, thanks again.

I will be pulling from upstream and rebasing frequently, even if not I
don't think it would be fine since I will be working on the static files
for the webui therefore it won't be a big issue.

cheers,
Kaveen


On 20 May 2016 at 13:22, Chris Hillery <chillery@hillery.land> wrote:

> On Fri, May 20, 2016 at 12:34 AM, <u.k.k.rodrigo@gmail.com> wrote:
>
> >
> >
> > Hello Chris,
> >
> >
> > I was planning to do the incremental commits to my fork and then at the
> > end of the summer to push my branch upstream,
> >
> >
> > Will this be a problem?
>
>
> If you rebase your work regularly, then you shouldn't have a problem
> proposing your changes all at once at the end of the summer. However I
> still think it will be easier both for you and for your reviewers if you
> propose smaller changes for review more often rather than saving everything
> up.
>
>
>
> > Or should I work on the main repo (in a branch)  and commit there,
>
>
> You won't be able to literally commit to the main repository, even in a
> branch. (I'm assuming that you're not an Apache Committer on the AsterixDB
> project - correct me if I'm wrong.) You should clone the Apache GitHub
> mirror instead.
>
> You could fork that mirror if you want, but if you do so, you'll need to
> keep the fork up to date in addition to rebasing your work. It's possibly
> worth doing if you are going to be batching up a lot of work before
> committing, because the fork then serves as an off-site backup of your work
> in progress. It's not really *necessary* to have a fork unless you intend
> to collaborate frequently with other developers, though.
>
>
> I did setup a Gerrit account, that's only for review right?
> >
>
> It's for review, yes, but a successful review is a pre-requisite for the
> code to actually get committed to the main repository. If you've never used
> Gerrit before, there's a bit of a learning curve and setup necessary.
> That's another reason I suggested more frequent commits - that way you
> figure out how to work with Gerrit in, say, June, instead of having to deal
> with those problems for the first time right at the end of the summer.
>
> Ceej
> aka Chris Hillery
>


-- 
Kaveen Rodrigo
Personal Website - (lifeofenigma.com)


Software Engineering Undergraduate,
Informatics Institute of Technology Sri Lanka (Affiliated with University
of Westminster, UK)


*Contact Information*

*Mobile* +94779684740

*E-Mail*  kaveen.2013175@iit.ac.lk | u.k.k.rodrigo@gmail.com

--001a114b415c6f5e7805334434cc--