Return-Path: X-Original-To: apmail-asterixdb-dev-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6F5B518DFE for ; Fri, 6 Nov 2015 22:11:48 +0000 (UTC) Received: (qmail 76723 invoked by uid 500); 6 Nov 2015 22:11:48 -0000 Delivered-To: apmail-asterixdb-dev-archive@asterixdb.apache.org Received: (qmail 76672 invoked by uid 500); 6 Nov 2015 22:11:48 -0000 Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list dev@asterixdb.incubator.apache.org Received: (qmail 76661 invoked by uid 99); 6 Nov 2015 22:11:48 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Nov 2015 22:11:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DE6F01A4255 for ; Fri, 6 Nov 2015 22:11:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.97 X-Spam-Level: X-Spam-Status: No, score=0.97 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id XgV5FiQq8C3z for ; Fri, 6 Nov 2015 22:11:47 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 5E7CD20A92 for ; Fri, 6 Nov 2015 22:11:46 +0000 (UTC) Received: (qmail 76550 invoked by uid 99); 6 Nov 2015 22:11:45 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Nov 2015 22:11:45 +0000 Received: from [10.17.1.105] (unknown [206.169.106.2]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 3DC4E1A0046 for ; Fri, 6 Nov 2015 22:11:45 +0000 (UTC) From: "Till Westmann" To: dev@asterixdb.incubator.apache.org Subject: handling InterruptedException Date: Fri, 06 Nov 2015 14:11:44 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: MailMate (1.9.2r5141) Hi, in the methods “log”, “getAndInitNewPage”, and “terminateLogFlusher” in LogManager and “terminate” and “call” in LogFlusher InterruptedExceptions are being caught and mostly ignored (at least the thread is not stopped). While that seems to be ok in LogManager.terminateLogFlusher (as the method will end anyway), for the other methods this happens in a loop that depends on modifications in another thread and so this might never happen if the other thread is stopped before performing those modifications. Now I think that this has been done carefully and that this all works fine, but it’s not obvious by looking at the code, and I’d like to understand if/why the current behavior is correct in the way we use it. Who could help me with that? Thanks, Till