asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann" <ti...@apache.org>
Subject Re: Code Review Checklist
Date Mon, 09 Nov 2015 17:39:00 GMT
Steven, I just tried to give you access, but I can’t find your user 
name in the Wiki.
Could you tell me your user name?

Thanks,
Till

On 9 Nov 2015, at 9:36, Till Westmann wrote:

> Yes, there’s a way around this, you need to either get the right 
> access rights (which I can do) or log in (if you already have them).
> However, I the question is, if we really want that. As it is a shared 
> resource, the checkmarks would be the same ones for everybody.
> Do you see a use for that?
>
> Cheers,
> Till
>
> On 9 Nov 2015, at 9:28, Steven Jacobs wrote:
>
>> Note- the checkboxes on this page are actually "checkable" and 
>> display an
>> error when you click on them. Is there a way around this?
>> Steven
>>
>> On Mon, Nov 9, 2015 at 9:22 AM, abdullah alamoudi <amoudi@apache.org> 
>> wrote:
>>
>>> Hi Dev,
>>> Just wanted to share with you that our code review checklist has 
>>> been
>>> uploaded to our wiki. Check it out at
>>> https://cwiki.apache.org/confluence/display/ASTERIXDB/Code+Review+Checklist
>>> , adhere to it and use it to make sure the code you're 
>>> submitting/reviewing
>>> meets our minimum standard.
>>>
>>> Also, feel free to contribute to the list, improve it, and if you 
>>> can
>>> automate some of the items in the list, that would be even better.
>>>
>>> Cheers,
>>> Abdullah.
>>>

Mime
View raw message