Return-Path: 
 <dev-return-2011-apmail-asterixdb-dev-archive=asterixdb.apache.org@asterixdb.incubator.apache.org>
X-Original-To: apmail-asterixdb-dev-archive@minotaur.apache.org
Delivered-To: apmail-asterixdb-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B03B110E71
	for <apmail-asterixdb-dev-archive@minotaur.apache.org>;
 Tue,  8 Sep 2015 19:49:37 +0000 (UTC)
Received: (qmail 77885 invoked by uid 500); 8 Sep 2015 19:49:37 -0000
Delivered-To: apmail-asterixdb-dev-archive@asterixdb.apache.org
Received: (qmail 77831 invoked by uid 500); 8 Sep 2015 19:49:37 -0000
Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@asterixdb.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@asterixdb.incubator.apache.org>
List-Post: <mailto:dev@asterixdb.incubator.apache.org>
List-Id: <dev.asterixdb.incubator.apache.org>
Reply-To: dev@asterixdb.incubator.apache.org
Delivered-To: mailing list dev@asterixdb.incubator.apache.org
Received: (qmail 77820 invoked by uid 99); 8 Sep 2015 19:49:37 -0000
Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2015 19:49:37 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org)
 with ESMTP id CBFD1C0BAD
	for <dev@asterixdb.apache.org>; Tue,  8 Sep 2015 19:49:36 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.995
X-Spam-Level: 
X-Spam-Status: No, score=0.995 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.006,
	URIBL_BLOCKED=0.001] autolearn=disabled
Received: from mx1-us-east.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new,
 port 10024)
	with ESMTP id vxk9YibCZBWR for <dev@asterixdb.apache.org>;
	Tue,  8 Sep 2015 19:49:28 +0000 (UTC)
Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu
 [128.195.14.130])
	by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with
 ESMTP id A93CD43AF9
	for <dev@asterixdb.incubator.apache.org>;
 Tue,  8 Sep 2015 19:49:28 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by unhygienix.ics.uci.edu (Postfix) with ESMTP id 793522408CB;
	Tue,  8 Sep 2015 12:47:21 -0700 (PDT)
Date: Tue, 8 Sep 2015 12:47:21 -0700
From: "Ian Maxon (Code Review)" <do-not-reply@asterix-gerrit.ics.uci.edu>
To: abdullah alamoudi <bamousaa@gmail.com>
CC: Murtadha Hubail <hubailmor@gmail.com>,
	Steven Jacobs <sjaco002@ucr.edu>,
	Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reply-To: imaxon@apache.org
X-Gerrit-MessageType: comment
Subject: Change in asterixdb[master]: Introduced Local Filesystem Feed Adapter
X-Gerrit-Change-Id: I707756e3b4c9ffca4b55ec9817a08e5c16333010
X-Gerrit-ChangeURL: <https://asterix-gerrit.ics.uci.edu/376>
X-Gerrit-Commit: a2cacd3842cb83f4f556d4aa09c3d274820b03db
In-Reply-To: 
 <gerrit.1441186019326.I707756e3b4c9ffca4b55ec9817a08e5c16333010@asterix-gerrit.ics.uci.edu>
References: 
 <gerrit.1441186019326.I707756e3b4c9ffca4b55ec9817a08e5c16333010@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20150908194721.793522408CB@unhygienix.ics.uci.edu>

Ian Maxon has posted comments on this change.

Change subject: Introduced Local Filesystem Feed Adapter
......................................................................


Patch Set 3:

(3 comments)

Just a few thoughts. Cool overall though! I'll try it myself soon...

https://asterix-gerrit.ics.uci.edu/#/c/376/3/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterix-app/src/test/resources/runtimets/testsuite.xml:

Line 25:     <test-group name="external">
Nit: spaces instead of tabs would be good :)


https://asterix-gerrit.ics.uci.edu/#/c/376/3/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LocalFileSystemFeedAdapter.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LocalFileSystemFeedAdapter.java:

Line 120:     }
Is it really the case, that no matter what exception we may eat here, we still want to continue?...


https://asterix-gerrit.ics.uci.edu/#/c/376/3/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java:

Line 319:         String[] builtInAdapterClassNames = new String[] {
> All of these need to be changed to dynamic class names. e.g. LocalFileSyste
+1 ;) But there's lots of other places in the code that are equally guilty of this.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/376
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I707756e3b4c9ffca4b55ec9817a08e5c16333010
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes