asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: This change fixes the sporadic connection refused errors aft...
Date Thu, 10 Sep 2015 09:59:14 GMT
abdullah alamoudi has posted comments on this change.

Change subject: This change fixes the sporadic connection refused errors after managix starts
up an Asterix instance. This can mostly be seen during asterix-installer tests. The fix basically
lets managix wait and listens through zookeeper for a signal from the cluster c
......................................................................


Patch Set 2:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/366/2//COMMIT_MSG
Commit Message:

Line 13: Thus, no more unexpected test failures.
> Could we clean up the commit message to only contain this text and the Chan
Done


https://asterix-gerrit.ics.uci.edu/#/c/366/2/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:

Line 119:         feedServer.join();
> Should there be code here to update Zookeeper that the cluster is now down?
It should be there. But I prefer we don't add it now and figure out the design of the lifecycle
and state reporting. I am very sure that if we add it now, it will be changed soon and it
will not add much of a value. actually, probably the only value we get from this change is
that tests don't fail.


https://asterix-gerrit.ics.uci.edu/#/c/366/2/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventServiceUtil.java
File asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventServiceUtil.java:

Line 186:     private static void injectAsterixLogPropertyFile(String asterixInstanceDir,
AsterixInstance asterixInstance)
> Sure, delete it.
Done


https://asterix-gerrit.ics.uci.edu/#/c/366/2/asterix-events/src/main/java/org/apache/asterix/event/service/ClusterStateWatcher.java
File asterix-events/src/main/java/org/apache/asterix/event/service/ClusterStateWatcher.java:

Line 41:         this.clusterStatePath = ZooKeeperService.ASTERIX_INSTANCE_BASE_PATH + File.separator
+ clusterName
> This path is used multiple times in different classes. It could be factored
Done


Line 46:     public ClusterState getClusterState() throws Exception {
> I think this method should be called something like "waitForClusterStart()"
Done


Line 63:     public void monitorStateChange() {
> Could this method be private? We don't want anyone calling it except the mo
Done


Line 76:                         clusterState = ClusterState.values()[(Integer.parseInt(Byte.toString(b[0])))];
> Can't we just cast a byte to an int without going through strings?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/366
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib730f50ab2fb492f3cf973d1cf2f03b34e24e5b3
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message