asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in hyracks[master]: This change fixes the sporadic connection refused errors aft...
Date Thu, 10 Sep 2015 09:53:26 GMT
abdullah alamoudi has posted comments on this change.

Change subject: This change fixes the sporadic connection refused errors after managix starts
up an Asterix instance. This can mostly be seen during asterix-installer tests. The fix basically
lets managix wait and listens through zookeeper for a signal from the cluster c
......................................................................


Patch Set 1:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/365/1//COMMIT_MSG
Commit Message:

Line 10: The following commits from your working branch will be included:
> please remove information about intermediate commits
Done


https://asterix-gerrit.ics.uci.edu/#/c/365/1/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java:

Line 70:     @Option(name = "-managix-ip", required = false, usage = "Sets the ip address
of the installer")
> This option doesn't belong in Hyracks as it isn't used by anything in Hyrac
I agree. Actually, instead of passing it to CCApplicationEntryPoint, I have removed the parameter
completely since it already exists in managix configuration xml files so this parameter is
redundant.


https://asterix-gerrit.ics.uci.edu/#/c/365/1/hyracks/hyracks-examples/text-example/textserver/pom.xml
File hyracks/hyracks-examples/text-example/textserver/pom.xml:

Line 152: 			<version>2.8.1</version>
> It looks like this is the only actual change other than whitespace. Why did
I am not sure about why this was required. It just refused to compile on my machine without
adding this dependency specifically.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/365
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0975308e1dc2650d8c2e50d58ff2c696b22eaaa4
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message