asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Hillery (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in hyracks[master]: This change fixes the sporadic connection refused errors aft...
Date Thu, 10 Sep 2015 03:33:17 GMT
Chris Hillery has posted comments on this change.

Change subject: This change fixes the sporadic connection refused errors after managix starts
up an Asterix instance. This can mostly be seen during asterix-installer tests. The fix basically
lets managix wait and listens through zookeeper for a signal from the cluster c
......................................................................


Patch Set 1: Code-Review-2

(2 comments)

Need to fix the review comments that have been made by others and move the Zookeeper command-line
option down to Asterix (see my comment).

I think this change (adding a "startup complete" callback to the entrypoint class) is probably
useful by itself. I do have strong reservations about the Zookeeper dependency as Till did,
but I will continue that conversation on the Asterix review.

https://asterix-gerrit.ics.uci.edu/#/c/365/1/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java:

Line 70:     @Option(name = "-managix-ip", required = false, usage = "Sets the ip address
of the installer")
This option doesn't belong in Hyracks as it isn't used by anything in Hyracks. Managix is
strictly an Asterix artifact.

There is a mechanism to provide app-specific command line options; Hyracks will pass them
down to the app entrypoint class. We use this already on the NC; see org.apache.asterix.hyracks.bootstrap.NCApplicationEntryPoint
(parameters are -metadata-port and -initial-run). We should add -zookeeper-ip down there,
not in Hyracks.


https://asterix-gerrit.ics.uci.edu/#/c/365/1/hyracks/hyracks-examples/text-example/textserver/pom.xml
File hyracks/hyracks-examples/text-example/textserver/pom.xml:

Line 152: 			<version>2.8.1</version>
It looks like this is the only actual change other than whitespace. Why did this change for
adding a Managix IP require adding an explicit dependency on surefire-junit4?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/365
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0975308e1dc2650d8c2e50d58ff2c696b22eaaa4
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message