asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: This change fixes the sporadic connection refused errors aft...
Date Wed, 09 Sep 2015 01:47:54 GMT
Till Westmann has posted comments on this change.

Change subject: This change fixes the sporadic connection refused errors after managix starts
up an Asterix instance. This can mostly be seen during asterix-installer tests. The fix basically
lets managix wait and listens through zookeeper for a signal from the cluster c
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/366/2//COMMIT_MSG
Commit Message:

Line 13: Thus, no more unexpected test failures.
Could we clean up the commit message to only contain this text and the Change-Id in the last
line?


https://asterix-gerrit.ics.uci.edu/#/c/366/2/asterix-events/src/main/java/org/apache/asterix/event/service/ClusterStateWatcher.java
File asterix-events/src/main/java/org/apache/asterix/event/service/ClusterStateWatcher.java:

Line 76:                         clusterState = ClusterState.values()[(Integer.parseInt(Byte.toString(b[0])))];
> You may use String to convert the byte[] instead of assuming the size to be
Can't we just cast a byte to an int without going through strings?
This is just an array access using a byte, right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/366
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib730f50ab2fb492f3cf973d1cf2f03b34e24e5b3
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message