Return-Path: X-Original-To: apmail-asterixdb-dev-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AF76017EF0 for ; Sun, 9 Aug 2015 21:54:07 +0000 (UTC) Received: (qmail 1164 invoked by uid 500); 9 Aug 2015 21:54:07 -0000 Delivered-To: apmail-asterixdb-dev-archive@asterixdb.apache.org Received: (qmail 1108 invoked by uid 500); 9 Aug 2015 21:54:07 -0000 Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list dev@asterixdb.incubator.apache.org Received: (qmail 1096 invoked by uid 99); 9 Aug 2015 21:54:07 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Aug 2015 21:54:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DF17919FEF2 for ; Sun, 9 Aug 2015 21:54:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.88 X-Spam-Level: ** X-Spam-Status: No, score=2.88 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id O_K85m1CC8cL for ; Sun, 9 Aug 2015 21:54:05 +0000 (UTC) Received: from mail-yk0-f182.google.com (mail-yk0-f182.google.com [209.85.160.182]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id BF80A42BE3 for ; Sun, 9 Aug 2015 21:54:05 +0000 (UTC) Received: by ykdt205 with SMTP id t205so45635822ykd.1 for ; Sun, 09 Aug 2015 14:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=GHRaXZTBriu0xx9mILLeOexo/E/YQRU3eqXooj9UCZc=; b=b5WRgPDJdiOo1yk8Z1hsEl13BHPd6XgmMmsFWZo/KdwAtJYMGetjkw7yruaHhuUAGf TSFtaI9wGAVZQwHDczWIZ0nXFOazoCTL+GtYKykgRNG56USAU2l25f18dvP65JOAOC2d HZ1rldnW2a69MoGlD/jjCt3AECWR3rezNK54OSRey2CTtc0ux+mPFpnbr2gEbaykbe19 mqqJ99CovPhVcXWSVWcp58u51bdVWHdd4Q4qu/bSfntP68wDdsx6e+UyaqIBA8mqpC5A EO73meCGWzYEtgxQ9okICuJ45o5rIXLLK5a09056cVr0f4V35vltw2QA/g+VSb5Mwhvt 6s/Q== MIME-Version: 1.0 X-Received: by 10.170.210.212 with SMTP id b203mr18312538ykf.110.1439157200453; Sun, 09 Aug 2015 14:53:20 -0700 (PDT) Received: by 10.37.37.142 with HTTP; Sun, 9 Aug 2015 14:53:20 -0700 (PDT) In-Reply-To: References: <20150809183616.EC273240EE2@unhygienix.ics.uci.edu> Date: Sun, 9 Aug 2015 14:53:20 -0700 Message-ID: Subject: Re: Change in hyracks[master]: This change includes: 1. avoid calling ByteBuffer.get() and ... From: Yingyi Bu To: Mike Carey Cc: dev@asterixdb.incubator.apache.org, Young-Seok Kim , Ian Maxon , Jenkins Content-Type: multipart/alternative; boundary=001a11398d92b5a647051ce7e504 --001a11398d92b5a647051ce7e504 Content-Type: text/plain; charset=UTF-8 X is the number of pages in the buffer cache. 2X or 3X refer to the hash table size. Best, Yingyi On Sun, Aug 9, 2015 at 2:51 PM, Mike Carey wrote: > Can someone give a high level hint about what the 2 or 3x is x'ing? > On Aug 9, 2015 11:38 AM, "Yingyi Bu (Code Review)" < > do-not-reply@asterix-gerrit.ics.uci.edu> wrote: > >> Yingyi Bu has posted comments on this change. >> >> Change subject: This change includes: 1. avoid calling ByteBuffer.get() >> and ByteBuffer.put() for bloom filter set/get operations. ByteBuffer will >> check boundaries of the index for get/put. It's a very frequent operation. >> 2. let the hash table size in BufferCache be 3X of >> ...................................................................... >> >> >> Patch Set 1: >> >> I don't have a strong opinion for the 3X thing. You guys decide... >> >> -- >> To view, visit https://asterix-gerrit.ics.uci.edu/345 >> To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings >> >> Gerrit-MessageType: comment >> Gerrit-Change-Id: Ifd47c410338ce557a494ab3605660bad1899e786 >> Gerrit-PatchSet: 1 >> Gerrit-Project: hyracks >> Gerrit-Branch: master >> Gerrit-Owner: Yingyi Bu >> Gerrit-Reviewer: Ian Maxon >> Gerrit-Reviewer: Jenkins >> Gerrit-Reviewer: Yingyi Bu >> Gerrit-Reviewer: Young-Seok Kim >> Gerrit-HasComments: No >> > --001a11398d92b5a647051ce7e504--