Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.incubator.apache.org
Date: Mon, 31 Aug 2015 10:07:32 -0700
From: "Steven Jacobs (Code Review)" <do-not-reply@asterix-gerrit.ics.uci.edu>
CC: Preston Carman <prestonc@apache.org>,
	Yingyi Bu <yingyib@google.com>, Yingyi Bu <buyingyi@gmail.com>,
	Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reply-To: sjaco002@ucr.edu
Subject: Change in hyracks[master]: Adapted Inline Variable rules to allow
 exceptions for nonfun...
In-Reply-To: 
 <gerrit.1440701127496.Ib990773ec36a3f51abef72ce6ceb7715aa1d5e37@asterix-gerrit.ics.uci.edu>
References: 
 <gerrit.1440701127496.Ib990773ec36a3f51abef72ce6ceb7715aa1d5e37@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20150831170732.9F6E5241001@unhygienix.ics.uci.edu>

Steven Jacobs has posted comments on this change.

Change subject: Adapted Inline Variable rules to allow exceptions for nonfunctional functions. Exceptions must be implemented by an inherited class.
......................................................................


Patch Set 1:

(1 comment)

Replied to Yingyi's comment.

https://asterix-gerrit.ics.uci.edu/#/c/368/1/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java
File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java:

Line 137:                             || (!funcExpr.isFunctional() && !createException(expr))) {
> What does createException(...) mean here?
This is created for subclasses. Another package, such as Asterrix, can override this function to add exceptions to the "only inline functional functions" rule. If you check out the Asterix code review, you can see where I used this ability.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib990773ec36a3f51abef72ce6ceb7715aa1d5e37
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-HasComments: Yes