Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.incubator.apache.org
Date: Sat, 29 Aug 2015 22:14:51 -0700
From: "Till Westmann (Code Review)" <do-not-reply@asterix-gerrit.ics.uci.edu>
To: Murtadha Hubail <hubailmor@gmail.com>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Young-Seok Kim <kisskys@gmail.com>, Yingyi Bu <yingyib@google.com>,
	Ian Maxon <imaxon@apache.org>, Yingyi Bu <buyingyi@gmail.com>
Reply-To: tillw@apache.org
Subject: Change in asterixdb[master]: Allow lazy loading for persistent local
 resources
In-Reply-To: 
 <gerrit.1438966742809.I48b9260a3280750145f6ddb3783673a299055910@asterix-gerrit.ics.uci.edu>
References: 
 <gerrit.1438966742809.I48b9260a3280750145f6ddb3783673a299055910@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20150830051451.AC65A240FC3@unhygienix.ics.uci.edu>

Till Westmann has posted comments on this change.

Change subject: Allow lazy loading for persistent local resources
......................................................................


Patch Set 5:

(7 comments)

Just a few small comments.

https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java
File asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java:

Line 290:         ILSMIndex lsmIndex = (ILSMIndex) indexLifecycleManager.getIndex(metadataIndex.getFile().toString());
Could we create a local variable for "metadataIndex.getFile().toString()"?


Line 639:         ILSMIndex lsmIndex = (ILSMIndex) indexLifecycleManager.getIndex(metadataIndex.getFile().toString());
Could we create a local variable for "metadataIndex.getFile().toString()"?


Line 973:             IIndex indexInstance = indexLifecycleManager.getIndex(index.getFile().toString());
Could we create a local variable for "index.getFile().toString()"?


Line 1049:         IIndex indexInstance = indexLifecycleManager.getIndex(index.getFile().toString());
Could we create a local variable for "index.getFile().toString()"?


Line 1087:                     .toString());
Another local variable here?


https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-transactions/pom.xml
File asterix-transactions/pom.xml:

Line 11: 	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
This seems to be a modification in the wrong direction. We shouldn't introduce tabs.


https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java
File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java:

Line 48:     private final Cache<String, LocalResource> resourcesCache;
> OK, fine for me. (though in many other places in the codebase, we usually u
I'd prefer "resourceCache" as well.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/344
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes