Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.incubator.apache.org
Date: Sat, 29 Aug 2015 22:02:41 -0700
From: "Till Westmann (Code Review)" <do-not-reply@asterix-gerrit.ics.uci.edu>
To: Murtadha Hubail <hubailmor@gmail.com>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Young-Seok Kim <kisskys@gmail.com>, Ian Maxon <imaxon@apache.org>,
	Yingyi Bu <yingyib@google.com>, Yingyi Bu <buyingyi@gmail.com>
Reply-To: tillw@apache.org
Subject: Change in hyracks[master]: Add support for persistent local resources
 to IndexLifecycle...
In-Reply-To: 
 <gerrit.1438959763130.I2e8e974fc2f746959639ce94351f8e419a7f9093@asterix-gerrit.ics.uci.edu>
References: 
 <gerrit.1438959763130.I2e8e974fc2f746959639ce94351f8e419a7f9093@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20150830050241.C0102241038@unhygienix.ics.uci.edu>

Till Westmann has posted comments on this change.

Change subject: Add support for persistent local resources to IndexLifecycleManager
......................................................................


Patch Set 3: Code-Review+1

(6 comments)

Look much better now (and I learned a lot), thanks!
My only remaining comments are about small code cleanups that would make things a littler easier to read (at least for me).

I'll leave the question about other users of the interface to Yingyi.

https://asterix-gerrit.ics.uci.edu/#/c/343/3/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java
File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java:

Line 71:             long resourceID = getResourceID();
Could we move the declaration of resourceID down to the place it is actually needed (inside the try-block)?


Line 73:             index = lcManager.getIndex(file.getFile().getPath());
Could we create a local variable for "file.getFile().getPath()"?


Line 104:             long resourceID = getResourceID();
Maybe we can inline resourceID?


Line 110:             index = lcManager.getIndex(file.getFile().getPath());
Could we create a local variable for "file.getFile().getPath()"?


Line 130:             index = lcManager.getIndex(file.getFile().getPath());
Could we create a local variable for "file.getFile().getPath()"?


https://asterix-gerrit.ics.uci.edu/#/c/343/3/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexLifecycleManager.java
File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexLifecycleManager.java:

Line 253:         return lr.getResourceId();
return lr == null ? -1 : lr.getResourceId() ? :)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/343
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e8e974fc2f746959639ce94351f8e419a7f9093
Gerrit-PatchSet: 3
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes