Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.incubator.apache.org
Date: Sat, 29 Aug 2015 09:57:07 -0700
From: "Yingyi Bu (Code Review)" <do-not-reply@asterix-gerrit.ics.uci.edu>
To: Murtadha Hubail <hubailmor@gmail.com>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Young-Seok Kim <kisskys@gmail.com>, Yingyi Bu <yingyib@google.com>,
	Ian Maxon <imaxon@apache.org>
Reply-To: buyingyi@gmail.com
Subject: Change in asterixdb[master]: Allow lazy loading for persistent local
 resources
In-Reply-To: 
 <gerrit.1438966742809.I48b9260a3280750145f6ddb3783673a299055910@asterix-gerrit.ics.uci.edu>
References: 
 <gerrit.1438966742809.I48b9260a3280750145f6ddb3783673a299055910@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20150829165707.61E76241050@unhygienix.ics.uci.edu>

Yingyi Bu has posted comments on this change.

Change subject: Allow lazy loading for persistent local resources
......................................................................


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java
File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java:

Line 205:     public HashMap<Long, LocalResource> loadAndGetAllResources() throws HyracksDataException {
> In my opinion, a disk-access-transparent ResourceCache would serve the same
Is it possible to have yet-another resourcesCache for that maps an ID to the Resource (or name string), so that we always use bounded amount of memory?

It looks not possible with the current physical metadata storage because the resources are physically identified by the metadata file name, unless we add other two files that one contains a <id, name_offset> map and the other contains all the names.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/344
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes