Return-Path: X-Original-To: apmail-asterixdb-dev-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B61CC102A6 for ; Fri, 28 Aug 2015 02:36:11 +0000 (UTC) Received: (qmail 19835 invoked by uid 500); 28 Aug 2015 02:36:11 -0000 Delivered-To: apmail-asterixdb-dev-archive@asterixdb.apache.org Received: (qmail 19777 invoked by uid 500); 28 Aug 2015 02:36:11 -0000 Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list dev@asterixdb.incubator.apache.org Received: (qmail 19764 invoked by uid 99); 28 Aug 2015 02:36:11 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Aug 2015 02:36:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id F309EC028F for ; Fri, 28 Aug 2015 02:36:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.995 X-Spam-Level: X-Spam-Status: No, score=0.995 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.006, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 0AmWHlHHXsCj for ; Fri, 28 Aug 2015 02:36:04 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTP id AFC7620384 for ; Fri, 28 Aug 2015 02:36:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id AE3B2240F98; Thu, 27 Aug 2015 19:34:07 -0700 (PDT) Date: Thu, 27 Aug 2015 19:34:07 -0700 From: "Yingyi Bu (Code Review)" To: Steven Jacobs CC: Preston Carman , Yingyi Bu , Jenkins Reply-To: buyingyi@gmail.com X-Gerrit-MessageType: comment Subject: Change in hyracks[master]: Adapted Inline Variable rules to allow exceptions for nonfun... X-Gerrit-Change-Id: Ib990773ec36a3f51abef72ce6ceb7715aa1d5e37 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2f71075dd4630254f1763ba8def6b3750802d0e5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20150828023407.AE3B2240F98@unhygienix.ics.uci.edu> Yingyi Bu has posted comments on this change. Change subject: Adapted Inline Variable rules to allow exceptions for nonfunctional functions. Exceptions must be implemented by an inherited class. ...................................................................... Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/368/1/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java: Line 137: || (!funcExpr.isFunctional() && !createException(expr))) { What does createException(...) mean here? Why does it always return false? -- To view, visit https://asterix-gerrit.ics.uci.edu/368 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib990773ec36a3f51abef72ce6ceb7715aa1d5e37 Gerrit-PatchSet: 1 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes