Return-Path: X-Original-To: apmail-asterixdb-dev-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 92C5110BEB for ; Thu, 20 Aug 2015 21:55:16 +0000 (UTC) Received: (qmail 80888 invoked by uid 500); 20 Aug 2015 21:55:16 -0000 Delivered-To: apmail-asterixdb-dev-archive@asterixdb.apache.org Received: (qmail 80843 invoked by uid 500); 20 Aug 2015 21:55:16 -0000 Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list dev@asterixdb.incubator.apache.org Received: (qmail 80052 invoked by uid 99); 20 Aug 2015 21:55:16 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2015 21:55:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A2B121AA916 for ; Thu, 20 Aug 2015 21:55:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.202 X-Spam-Level: ** X-Spam-Status: No, score=2.202 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, MISSING_HEADERS=1.207, RP_MATCHES_RCVD=-0.006, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id OJYly7Hu4dIA for ; Thu, 20 Aug 2015 21:55:09 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTP id 8051D42B98 for ; Thu, 20 Aug 2015 21:55:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id B796624101D; Thu, 20 Aug 2015 14:53:18 -0700 (PDT) Date: Thu, 20 Aug 2015 14:53:18 -0700 From: "Heri Ramampiaro (Code Review)" CC: Steven Jacobs , Preston Carman , Ian Maxon , Jenkins , Till Westmann Reply-To: heriram@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Merging with the current master (+ Correcting RecordBuilder ... X-Gerrit-Change-Id: I3621ebdd71c7cd91b50d77a972ad863cea7fcbc2 X-Gerrit-ChangeURL: X-Gerrit-Commit: aa10b344c950081be2cb2d548fc833282e3084ea In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20150820215318.B796624101D@unhygienix.ics.uci.edu> Heri Ramampiaro has posted comments on this change. Change subject: Merging with the current master (+ Correcting RecordBuilder instatiation in RecordAddFieldsDescriptor) ...................................................................... Patch Set 9: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/298/9/asterix-om/src/main/java/edu/uci/ics/asterix/om/functions/AsterixBuiltinFunctions.java File asterix-om/src/main/java/edu/uci/ics/asterix/om/functions/AsterixBuiltinFunctions.java: Line 1005: addFunction(CURRENT_TIME, ATimeTypeComputer.INSTANCE, false); > why did these go false? I actually do not know. They appear to have the same values as in the current master version. In any cases, I did not change them. If they are supposed to be 'true', I can surely change them... https://asterix-gerrit.ics.uci.edu/#/c/298/9/asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/functions/records/RecordAddFieldsDescriptor.java File asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/functions/records/RecordAddFieldsDescriptor.java: Line 124: recordBuilder = new RecordBuilder(); > We are creating a new record builder for every tuple? Thank you pointing this out. I was just not careful. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3621ebdd71c7cd91b50d77a972ad863cea7fcbc2 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro Gerrit-Reviewer: Heri Ramampiaro Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes