Return-Path: X-Original-To: apmail-asterixdb-dev-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 088C3186B6 for ; Wed, 12 Aug 2015 23:27:00 +0000 (UTC) Received: (qmail 13213 invoked by uid 500); 12 Aug 2015 23:27:00 -0000 Delivered-To: apmail-asterixdb-dev-archive@asterixdb.apache.org Received: (qmail 13153 invoked by uid 500); 12 Aug 2015 23:26:59 -0000 Mailing-List: contact dev-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list dev@asterixdb.incubator.apache.org Received: (qmail 13142 invoked by uid 99); 12 Aug 2015 23:26:59 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Aug 2015 23:26:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2A6FC1A9F07 for ; Wed, 12 Aug 2015 23:26:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.779 X-Spam-Level: X-Spam-Status: No, score=0.779 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.222, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id G-KLzuhtWvOn for ; Wed, 12 Aug 2015 23:26:56 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTP id 5C8D744035 for ; Wed, 12 Aug 2015 23:22:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 8DF41240F83; Wed, 12 Aug 2015 16:20:30 -0700 (PDT) Date: Wed, 12 Aug 2015 16:20:30 -0700 From: "Young-Seok Kim (Code Review)" To: Ian Maxon CC: Jenkins , Murtadha Hubail Reply-To: kisskys@gmail.com X-Gerrit-MessageType: comment Subject: Change in hyracks[master]: Make LSM bulkload append-only and write-once. X-Gerrit-Change-Id: I80fb891b5310252143854a336b591bf3f8cd4ba7 X-Gerrit-ChangeURL: X-Gerrit-Commit: cfa459e37fdb2ea206c24992a80b60eb0086aea4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20150812232030.8DF41240F83@unhygienix.ics.uci.edu> Young-Seok Kim has posted comments on this change. Change subject: Make LSM bulkload append-only and write-once. ...................................................................... Patch Set 17: (3 comments) minor comments. to be continued... https://asterix-gerrit.ics.uci.edu/#/c/255/17/hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java File hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java: Line 71: //System.out.println("Searching disk component: "+btreeAccessors[i].hashCode()); let's remove this if unnecessary https://asterix-gerrit.ics.uci.edu/#/c/255/17/hyracks/hyracks-storage-am-lsm-common/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/common/api/ILSMComponentFilterManager.java File hyracks/hyracks-storage-am-lsm-common/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/common/api/ILSMComponentFilterManager.java: Line 21: import edu.uci.ics.hyracks.storage.am.common.api.IIndexBulkLoader; This is usless Line 23: import edu.uci.ics.hyracks.storage.am.common.impls.AbstractTreeIndex.AbstractTreeIndexBulkLoader; This is usless -- To view, visit https://asterix-gerrit.ics.uci.edu/255 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fb891b5310252143854a336b591bf3f8cd4ba7 Gerrit-PatchSet: 17 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Young-Seok Kim Gerrit-HasComments: Yes