asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: Allow lazy loading for persistent local resources
Date Sun, 30 Aug 2015 20:27:01 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Allow lazy loading for persistent local resources
......................................................................


Patch Set 5:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java
File asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java:

Line 290:         ILSMIndex lsmIndex = (ILSMIndex) indexLifecycleManager.getIndex(metadataIndex.getFile().toString());
> Could we create a local variable for "metadataIndex.getFile().toString()"?
Done


Line 639:         ILSMIndex lsmIndex = (ILSMIndex) indexLifecycleManager.getIndex(metadataIndex.getFile().toString());
> Could we create a local variable for "metadataIndex.getFile().toString()"?
Done


Line 973:             IIndex indexInstance = indexLifecycleManager.getIndex(index.getFile().toString());
> Could we create a local variable for "index.getFile().toString()"?
Done


Line 1049:         IIndex indexInstance = indexLifecycleManager.getIndex(index.getFile().toString());
> Could we create a local variable for "index.getFile().toString()"?
Done


Line 1087:                     .toString());
> Another local variable here?
Done


https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-transactions/pom.xml
File asterix-transactions/pom.xml:

Line 11: 	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
> This seems to be a modification in the wrong direction. We shouldn't introd
This is eclipse auto formatting for XML files. I will revert the formatting changes to this
file and just add the new dependency until there is an agreement on whether to auto format
the POM files or not.


https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java
File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java:

Line 48:     private final Cache<String, LocalResource> resourcesCache;
> I'd prefer "resourceCache" as well.
Alright, I will give you this one :)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/344
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message