asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: Allow lazy loading for persistent local resources
Date Sat, 29 Aug 2015 16:29:49 GMT
Yingyi Bu has posted comments on this change.

Change subject: Allow lazy loading for persistent local resources
......................................................................


Patch Set 5:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java
File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java:

Line 48:     private final Cache<String, LocalResource> resourcesCache;
> I'm not sure if we have a naming standard. I think resourcesCache is better
OK, fine for me. (though in many other places in the codebase, we usually use singular for
attributive nouns).


Line 205:     public HashMap<Long, LocalResource> loadAndGetAllResources() throws HyracksDataException
{
> RecoveryManager needs to have the complete map to use it during recovery.
In my opinion, a disk-access-transparent ResourceCache would serve the same purpose.  If a
lookup hit the cache, just return the resource; otherwise, read the resource from disk and
invalidate another cache line.  

The purpose for this change is for the situation that there are ~1M datasets in AsterixDB.
 But if we load everything here into the map, we probably will run into the same memory issue.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/344
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message