asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in hyracks[master]: Add support for persistent local resources to IndexLifecycle...
Date Sat, 29 Aug 2015 06:19:15 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Add support for persistent local resources to IndexLifecycleManager
......................................................................


Patch Set 2:

Yes, the goal is correct, and you dug correctly. In the logs, we have the dataset id and the
resource id. We don't store the string.

During recovery (REDO only), we load all resources and construct the mapping while loading
them.

During aborts (UNDO), the indexes are guaranteed to be open, so we fetch them using the dataset
id and the resource id. This mapping is maintained in DatasetLifeCycleManager for the opened
datasets only, and removed once they are closed.

Therefore, strings are enough for the API between IndexDataFlowHelper and IndexLifeCycleManager.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/343
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e8e974fc2f746959639ce94351f8e419a7f9093
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: No

Mime
View raw message