asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <>
Subject Change in asterixdb[master]: Fixed issue 920: consecutive index-nested-loop joins fail. I...
Date Mon, 24 Aug 2015 19:15:54 GMT
Yingyi Bu has posted comments on this change.

Change subject: Fixed issue 920: consecutive index-nested-loop joins fail. Index-nested-loop
join now tries to use an index on the inner relation first.

Patch Set 3:

File asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/

Line 549:                     if (funcVarIndex == -1) {
Can you reuse the code with the first case above?
It looks they both do nearly the same thing and the code could be shared.
File asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/

Line 157:             // Check whether we can remove the indexes from the outer relations
File asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/

Line 72:     public List<Mutable<ILogicalOperator>> additionalDataSourceRefs =
Can you name the variables more explicitly?
For example, "additional" --> "indexJoinOuter".
It's not so clear to readers that "additional" is for the "outer" or for the "inner".

Line 126:             // There can be multiple unnest-map or datasource-scan operators
This code only works for two unnest-maps?
If that's the case, can you update "multiple" to be "two"?

Line 157:                     if (additionalDataSourceRefs == null) {
Can you move if(additionalDataSourceRefs==null) into initalizeAdditionalDataSources(...)?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I63e445950aaf5f1e756757c9f1d6167a6fe6b12b
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Pouria Pirzadeh <>
Gerrit-Reviewer: Taewoo Kim <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-HasComments: Yes

View raw message