asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: Changed metadata storage format for nullable field types. Mo...
Date Mon, 17 Aug 2015 23:47:25 GMT
Till Westmann has posted comments on this change.

Change subject: Changed metadata storage format for nullable field types. Moved field name
generation to the client out of metadata node code. Changed naming scheme for autogenerated
types. Moved GroupName, CompactionPolicy & CompactionPolicyProperties fields up from Ext
......................................................................


Patch Set 10: Code-Review+2

(2 comments)

I've added 2 small comments.

We can either submit this as-is or address the 2 comments and bring my +2 forward to the changed
version (if nothing else changes :) ). 
Both approached work for me.

https://asterix-gerrit.ics.uci.edu/#/c/323/10/asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

Line 199:             }
Why are those candidates removed? Could we add a comment?


https://asterix-gerrit.ics.uci.edu/#/c/323/10/asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
File asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm:

Line 2: , { "DataverseName": "Metadata", "DatasetName": "Dataset", "IndexName": "GroupName",
"IndexStructure": "BTREE", "SearchKey": [ [ "GroupName" ], [ "DataverseName" ], [ "DatasetName"
] ], "IsPrimary": false, "Timestamp": "Tue Sep 23 14:44:50 PDT 2014", "PendingOp": 0, "SearchKeyType":
[ "null", "null", "null" ] }		
Can this whitespace be removed?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/323
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I223aded8aaf80f0688358899c0e8b0d6988fac93
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message