asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in hyracks[master]: Optimization in adminconsole API in Hyracks to optimize the ...
Date Mon, 17 Aug 2015 18:00:47 GMT
Steven Jacobs has posted comments on this change.

Change subject: Optimization in adminconsole API in Hyracks to optimize the JSON data being
sent. 
......................................................................


Patch Set 3:

(5 comments)

Just a few formatting things. By the way, are you applying the Asterix formatting when you
save files? If not, I can show you how.

https://asterix-gerrit.ics.uci.edu/#/c/355/3/hyracks/hyracks-control/hyracks-control-cc/src/main/java/edu/uci/ics/hyracks/control/cc/job/JobRun.java
File hyracks/hyracks-control/hyracks-control-cc/src/main/java/edu/uci/ics/hyracks/control/cc/job/JobRun.java:

Line 231: 
Is this a formatting fix? If not, it should be taken out.


https://asterix-gerrit.ics.uci.edu/#/c/355/3/hyracks/hyracks-control/hyracks-control-cc/src/main/java/edu/uci/ics/hyracks/control/cc/web/JobsRESTAPIFunction.java
File hyracks/hyracks-control/hyracks-control-cc/src/main/java/edu/uci/ics/hyracks/control/cc/web/JobsRESTAPIFunction.java:

Line 63:                     }*/
Do we still need the commented out code?


https://asterix-gerrit.ics.uci.edu/#/c/355/3/hyracks/hyracks-control/hyracks-control-cc/src/main/resources/edu/uci/ics/hyracks/control/cc/adminconsole/pages/JobDetailsPage.html
File hyracks/hyracks-control/hyracks-control-cc/src/main/resources/edu/uci/ics/hyracks/control/cc/adminconsole/pages/JobDetailsPage.html:

Line 17:     </div>-->
Do we need to keep the comment?


Line 24:     <div wicket:id="activity-cluster-graph"> <!--style="display: none;"-->
</div>
same


Line 33:             </td>
same


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/355
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbbb326dfc9b0756184be50287a8d8c57aa493e3
Gerrit-PatchSet: 3
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Pritom Ahmed <pritom.11@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-HasComments: Yes

Mime
View raw message