asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <>
Subject Change in asterixdb[master]: Allow lazy loading for persistent local resources
Date Sun, 16 Aug 2015 22:54:47 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Allow lazy loading for persistent local resources

Patch Set 3:

File asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/

Line 1085:         long resourceID = MetadataPrimaryIndexes.DATASET_DATASET.getResourceID();
> This is not used anymore. So let's remove this.
File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/

Line 51:     private static final int MAX_CACHED_RESOURCES = 100;
> Why 100? 100 seems small number considering the number of resources = (#dat
Changed to 1000.

Line 146:                 return readLocalResource(resourceFile);
> why should this be read again? Shouldn't be?
It shouldn't be. Just an old code before introducing the cache. Done.
File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/service/recovery/

Line 249:         resourcesMap = ((PersistentLocalResourceRepository) localResourceRepository).loadAndGetAllResources();
> When is resourceMap cleaned up after this recovery? Seems like all resource
That's right. I made the map initially local to startRecovery method then changed it to global
because I thought I would need to use it on redo. I changed it back to be local to startRecovery.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Murtadha Hubail <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-Reviewer: Young-Seok Kim <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message