asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: Allow lazy loading for persistent local resources
Date Sun, 16 Aug 2015 22:54:47 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Allow lazy loading for persistent local resources
......................................................................


Patch Set 3:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/344/3/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java
File asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java:

Line 1085:         long resourceID = MetadataPrimaryIndexes.DATASET_DATASET.getResourceID();
> This is not used anymore. So let's remove this.
Done


https://asterix-gerrit.ics.uci.edu/#/c/344/3/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java
File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java:

Line 51:     private static final int MAX_CACHED_RESOURCES = 100;
> Why 100? 100 seems small number considering the number of resources = (#dat
Changed to 1000.


Line 146:                 return readLocalResource(resourceFile);
> why should this be read again? Shouldn't be?
It shouldn't be. Just an old code before introducing the cache. Done.


https://asterix-gerrit.ics.uci.edu/#/c/344/3/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/service/recovery/RecoveryManager.java
File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/service/recovery/RecoveryManager.java:

Line 249:         resourcesMap = ((PersistentLocalResourceRepository) localResourceRepository).loadAndGetAllResources();
> When is resourceMap cleaned up after this recovery? Seems like all resource
That's right. I made the map initially local to startRecovery method then changed it to global
because I thought I would need to use it on redo. I changed it back to be local to startRecovery.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/344
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message