asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Young-Seok Kim (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: Allow lazy loading for persistent local resources
Date Sun, 16 Aug 2015 21:48:06 GMT
Young-Seok Kim has posted comments on this change.

Change subject: Allow lazy loading for persistent local resources
......................................................................


Patch Set 3:

(4 comments)

I added comments.
Please address them.

https://asterix-gerrit.ics.uci.edu/#/c/344/3/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java
File asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java:

Line 1085:         long resourceID = MetadataPrimaryIndexes.DATASET_DATASET.getResourceID();
This is not used anymore. So let's remove this.


https://asterix-gerrit.ics.uci.edu/#/c/344/3/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java
File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java:

Line 51:     private static final int MAX_CACHED_RESOURCES = 100;
Why 100? 100 seems small number considering the number of resources = (#dataset + #secondary
index) * #partition


Line 146:                 return readLocalResource(resourceFile);
why should this be read again? Shouldn't be?


https://asterix-gerrit.ics.uci.edu/#/c/344/3/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/service/recovery/RecoveryManager.java
File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/service/recovery/RecoveryManager.java:

Line 249:         resourcesMap = ((PersistentLocalResourceRepository) localResourceRepository).loadAndGetAllResources();
When is resourceMap cleaned up after this recovery? Seems like all resource in the map are
never cleaned up in this code, right? This map is supposed be cleaned up at the end of recovery,
right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/344
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message